[Security Solution][Endpoint][Host Isolation] Fixes bug to remove excess host metadata status toasts on non user initiated errors #105331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkiino
added
Feature:Endpoint
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
|
Pinging @elastic/esecurity-onboarding-and-lifecycle-mgt (Feature:Endpoint) |
kevinlog
reviewed
Jul 12, 2021
| @@ -65,7 +64,8 @@ export const useHostIsolationStatus = ({ | |||
| setPendingUnisolation(data[0].pending_actions?.unisolate ?? 0); | |||
| } | |||
| } catch (error) { | |||
| addError(error.message, { title: ISOLATION_PENDING_FAILURE }); | |||
| // silently catch non-user initiated error | |||
| return; | |||
There was a problem hiding this comment.
I wonder if we could be a bit more specific on the errors that remain silent in the future.
There was a problem hiding this comment.
i think if there are certain errors we want to catch / call out we can do so, i'm just not sure which ones we would want to call out i guess
kevinlog
approved these changes
Jul 12, 2021
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
This was referenced Jul 13, 2021
parkiino
added a commit
to parkiino/kibana
that referenced
this pull request
Jul 13, 2021
…ess host metadata status toasts on non user initiated errors (elastic#105331)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 13, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (292 commits) bring back KQL autocomplete in timeline + fix last updated (elastic#105380) [Maps] Change TOC pop-up wording to reflect filter change, not search bar change (elastic#105163) Updating urls to upstream elastic repo (elastic#105250) [Maps] Move new vector layer wizard card down (elastic#104797) Exclude registering the cases feature if not enabled (elastic#105292) [Uptime] Alerts - Monitor status alert - check monitor status by monitor.timespan (elastic#104541) updated UI copy (elastic#105184) Log a warning when documents of unknown types are detected during migration (elastic#105213) [Logs UI] Register log threshold rule as lifecycle rule (elastic#104341) [Ingest pipelines] add network direction processor (elastic#103436) [Console] Autocomplete definitions (manual backport) (elastic#105086) [Security Solution] User can make Exceptions for Memory protection alerts (elastic#102196) [Lens] Formula: add validation for multiple field/metrics (elastic#104092) Removing async from file upload and data visualizer plugins start lifecycle (elastic#105197) Fix error when validating the form with non blocking validations (elastic#103629) [ML] Fix "View by" swim lane with applied filter and sorting by score (elastic#105217) Update dependency @elastic/charts to v32 (elastic#104625) [CTI] shortens large numbers on Dashboard Link Panel (elastic#105269) [Security Solution][Endpoint][Host Isolation] Fixes bug to remove excess host metadata status toasts on non user initiated errors (elastic#105331) [Cases] Fix pushing alerts count on every push to external service (elastic#105030) ... # Conflicts: # x-pack/plugins/reporting/common/types.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unhealthybadge flashes right before the actual agent status badge finally loads. The default during the loading state is now replaced with a text-.Screenshots
A dash shows right before the actual agent status is loaded
Unenrolled badge for 404 error, Take Action button is disabled
