Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix "View by" swim lane with applied filter and sorting by score #105217

Merged
merged 5 commits into from
Jul 13, 2021
Merged

[ML] Fix "View by" swim lane with applied filter and sorting by score #105217

merged 5 commits into from
Jul 13, 2021

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Jul 12, 2021 •
edited
Loading

Summary

Ensures the 'view by' swim lane is always displayed in the Anomaly Explorer when a filter has been applied to the view, but at the time of the selected cell in the 'overall' swim lane the influencer score for the filtered entity(s) is zero.

  • Fixes "View by" swim lane with applied influencers filter and sorting by max anomaly score.
  • Fixes positioning of the loading indicator
  • Fixes updating the query bar input with the "Add filter" button after manual clean up

Before:
Jul-12-2021 15-09-07

After:
Jul-12-2021 15-10-24

Checklist

@darnautov darnautov added release_note:fix :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 12, 2021
@darnautov darnautov self-assigned this Jul 12, 2021
@darnautov darnautov requested a review from a team as a code owner July 12, 2021 13:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson
Copy link
Contributor

Not related to the changes in this PR, as I can reproduce this with and without these changes, but for reference, here is an example of how sometimes the clicked on Top influencer doesn't end up populating the query bar:

ae_query_bar_empty

peteharverson
peteharverson approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM. Noted for reference a remaining issue where a filter applied from the Top Influencers list sometimes doesn't populate the query bar.

peteharverson
peteharverson approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest edit and LGTM

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM ⚡

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
ml 273 274 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +5.0B
Unknown metric groups

API count

id before after diff
ml 277 278 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 9ccbbef into elastic:master Jul 13, 2021
@darnautov darnautov deleted the ml-fix-swim-lane-exporer-filter branch July 13, 2021 08:03
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 13, 2021
@darnautov @kibanamachine
[ML] Fix "View by" swim lane with applied filter and sorting by score (…
f7f958c 
…elastic#105217)

* [ML] fix top influencers fetch with filter selection

* [ML] add relative position to the chart container

* [ML] fix ts

* [ML] fix updating search input from influencer filter
@kibanamachine kibanamachine mentioned this pull request Jul 13, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 13, 2021
@darnautov @kibanamachine
[ML] Fix "View by" swim lane with applied filter and sorting by score (…
2f2da8c 
…elastic#105217)

* [ML] fix top influencers fetch with filter selection

* [ML] add relative position to the chart container

* [ML] fix ts

* [ML] fix updating search input from influencer filter
@kibanamachine kibanamachine mentioned this pull request Jul 13, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 13, 2021
@kibanamachine @darnautov
[ML] Fix "View by" swim lane with applied filter and sorting by score (…
dc4c4c9 
…#105217) (#105391)

* [ML] fix top influencers fetch with filter selection

* [ML] add relative position to the chart container

* [ML] fix ts

* [ML] fix updating search input from influencer filter

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 13, 2021
@kibanamachine @darnautov
[ML] Fix "View by" swim lane with applied filter and sorting by score (…
a303b74 
…#105217) (#105392)

* [ML] fix top influencers fetch with filter selection

* [ML] add relative position to the chart container

* [ML] fix ts

* [ML] fix updating search input from influencer filter

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 13, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/new…
182ec47 
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (292 commits)
  bring back KQL autocomplete in timeline + fix last updated (elastic#105380)
  [Maps] Change TOC pop-up wording to reflect filter change, not search bar change (elastic#105163)
  Updating urls to upstream elastic repo (elastic#105250)
  [Maps] Move new vector layer wizard card down (elastic#104797)
  Exclude registering the cases feature if not enabled (elastic#105292)
  [Uptime] Alerts - Monitor status alert - check monitor status by monitor.timespan (elastic#104541)
  updated UI copy (elastic#105184)
  Log a warning when documents of unknown types are detected during migration (elastic#105213)
  [Logs UI] Register log threshold rule as lifecycle rule (elastic#104341)
  [Ingest pipelines] add network direction processor (elastic#103436)
  [Console] Autocomplete definitions (manual backport) (elastic#105086)
  [Security Solution] User can make Exceptions for Memory protection alerts (elastic#102196)
  [Lens] Formula: add validation for multiple field/metrics (elastic#104092)
  Removing async from file upload and data visualizer plugins start lifecycle (elastic#105197)
  Fix error when validating the form with non blocking validations (elastic#103629)
  [ML] Fix "View by" swim lane with applied filter and sorting by score  (elastic#105217)
  Update dependency @elastic/charts to v32 (elastic#104625)
  [CTI] shortens large numbers on Dashboard Link Panel (elastic#105269)
  [Security Solution][Endpoint][Host Isolation] Fixes bug to remove excess host metadata status toasts on non user initiated errors (elastic#105331)
  [Cases] Fix pushing alerts count on every push to external service (elastic#105030)
  ...

# Conflicts:
#	x-pack/plugins/reporting/common/types.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

Assignees

@darnautov darnautov

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darnautov @elasticmachine @peteharverson @kibanamachine @alvarezmelissa87