Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Add empty string validation for Tags and Authors #101756

Merged
merged 1 commit into from
Jul 13, 2021
Merged

[Security Solution][Detections] Add empty string validation for Tags and Authors #101756

merged 1 commit into from
Jul 13, 2021

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Jun 9, 2021 •
edited
Loading

Summary

issue: #91821

Adds a validation that doesn't allow empty strings for Tags and Authors.

UI when the user tries to add and empty string (" ")

Screenshot 2021-06-09 at 15 46 01
Screenshot 2021-06-09 at 15 45 35

Checklist

Delete any items that are not applicable to this PR.

@machadoum machadoum added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. 7.14 candidate labels Jun 9, 2021
@machadoum machadoum self-assigned this Jun 9, 2021
@machadoum machadoum force-pushed the siem-detections-issue-91821 branch from f5e3d13 to fbd3ace Compare June 9, 2021 15:16
@machadoum machadoum requested a review from cnasikas June 9, 2021 15:17
@machadoum machadoum marked this pull request as ready for review June 9, 2021 15:20
@machadoum machadoum requested a review from a team as a code owner June 9, 2021 15:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@machadoum machadoum changed the title Add empty string validation for Tags and Authors [Security Solution][Detections] Add empty string validation for Tags and Authors Jun 14, 2021
@machadoum machadoum force-pushed the siem-detections-issue-91821 branch from 35e4279 to 7cdf967 Compare June 14, 2021 14:09
@sebelga sebelga mentioned this pull request Jun 16, 2021
Closed
@machadoum
Copy link
Member Author

This PR is waiting for #102338 to be closed. After that, the fix will be a one-liner:

{ validator: emptyField(...), type: VALIDATION_TYPES.ARRAY_ITEM }

@spalger spalger added v7.15.0 and removed v7.14.0 labels Jun 30, 2021
@machadoum machadoum force-pushed the siem-detections-issue-91821 branch from 7cdf967 to e283a86 Compare July 13, 2021 13:02
@machadoum machadoum force-pushed the siem-detections-issue-91821 branch from e283a86 to 22289e6 Compare July 13, 2021 13:12
@machadoum
Copy link
Member Author

Now that PR #103629 is merged, we can reuse the emptyString validator for this scenario. The changes required are minimal. @cnasikas Could you take a second look?

cnasikas
cnasikas approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your patience!

@machadoum machadoum merged commit 18780bc into elastic:master Jul 13, 2021
machadoum added a commit to machadoum/kibana that referenced this pull request Jul 13, 2021
@machadoum
Add empty string validation for Tags and Authors (elastic#101756)
db13d79
@machadoum machadoum mentioned this pull request Jul 13, 2021
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 15, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@cnasikas cnasikas added v7.14.0 and removed v7.14.0 labels Jul 16, 2021
@cnasikas cnasikas mentioned this pull request Jul 16, 2021
Closed
machadoum added a commit that referenced this pull request Jul 16, 2021
@machadoum @kibanamachine
Add empty string validation for Tags and Authors (#101756) (#105479)
e766f3f 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 16, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.3MB 6.3MB +696.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet left review comments

@sebelga sebelga sebelga left review comments

@cnasikas cnasikas cnasikas approved these changes

Assignees

@machadoum machadoum

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@machadoum @elasticmachine @kibanamachine @pgayvallet @sebelga @cnasikas @spalger