Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Change TOC pop-up wording to reflect filter change, not search bar change #105163

Merged
merged 3 commits into from
Jul 13, 2021
Merged

[Maps] Change TOC pop-up wording to reflect filter change, not search bar change #105163

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1af848
Change pop-up wording
Jul 9, 2021
f2e6b35
Review feedback. Update wording
Jul 12, 2021
b80cc20
Merge remote-tracking branch 'upstream/master' into change-filtered-r…
Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ght_side_controls/layer_control/layer_toc/toc_entry/toc_entry_button/toc_entry_button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export class TOCEntryButton extends Component<Props, State> {
footnotes.push({
icon: <EuiIcon color="subdued" type="filter" size="s" />,
message: i18n.translate('xpack.maps.layer.isUsingSearchMsg', {
defaultMessage: 'Results narrowed by search bar',
defaultMessage: 'Results narrowed by filter',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gchaps Is there a word or phrase used to address the search bar in Kibana? Looking at https://www.elastic.co/guide/en/kibana/7.13/kibana-concepts-analysts.html#kibana-concepts-searching-your-data there does not appear to be one.

Copy link
Contributor

@gchaps gchaps Jul 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In docs, we use search query or query for a request for information about data. Could the tooltip be this:

Results narrowed by your query and filters.

OR

Results narrowed by your search query and filters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the wording to "Results narrowed by query and filters", just removed "your" to generally match other wording in the Maps app

}),
});
}
Expand Down