Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #1283 backports commits from release 2.0 branch to master #1285

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Mar 11, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

This PR backports the changes from the release_v2.0 branch to master and sets the website links from v2.0.0 to master

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

elBoberido and others added 30 commits March 5, 2022 11:37
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
…d' directory already exists, rewrite readme

Signed-off-by: Christian Eltzschig <me@elchris.org>
…ge occurences

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
…teway (for both directions)

Signed-off-by: Christian Eltzschig <me@elchris.org>
…-optional-expected-md

iox-eclipse-iceoryx#743 Validation of "How optional and error values are returned in iceoryx"
Signed-off-by: Christian Eltzschig <me@elchris.org>
…oAppName

Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…-installation-guide-for-contributors

iox-eclipse-iceoryx#743 Validation of "Installation guide for contributors"
MatthiasKillat and others added 14 commits March 11, 2022 10:37
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
Declaring a function in C that takes no argument requires "(void)".
With strict warning settings, C compilers will issue a warning.

Signed-off-by: Erik Boasson <eb@ilities.com>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Matthias Killat <matthias.killat@apex.ai>
…r-prototypes-in-config-h

iox-eclipse-iceoryx#1280 use proper prototypes in C binding
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
…ber-requesting-history-support-should-match-with-any-history

Iox eclipse-iceoryx#1278 subscriber requesting history support should match with any history
…lace-conflicts-tag-hoofs-package

Iox eclipse-iceoryx#1126 add replace conflicts tag hoofs package
…s-to-v2-0-0

iox-eclipse-iceoryx#743 Set all documentation links to `v2.0.0`
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #1285 (4008a90) into master (afdaa82) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1285      +/-   ##
==========================================
- Coverage   78.92%   78.91%   -0.02%     
==========================================
  Files         370      370              
  Lines       14706    14705       -1     
  Branches     2059     2059              
==========================================
- Hits        11607    11604       -3     
- Misses       2418     2419       +1     
- Partials      681      682       +1     
Flag Coverage Δ
unittests 78.14% <100.00%> (-0.02%) ⬇️
unittests_timing 15.48% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_posh/source/roudi/port_manager.cpp 84.24% <100.00%> (-0.03%) ⬇️
iceoryx_hoofs/source/concurrent/loffli.cpp 80.00% <0.00%> (-11.43%) ⬇️
...nternal/roudi/introspection/port_introspection.inl 82.84% <0.00%> (+0.72%) ⬆️

@MatthiasKillat MatthiasKillat self-requested a review March 14, 2022 08:37
@elBoberido elBoberido merged commit 0696c01 into eclipse-iceoryx:master Mar 14, 2022
@elBoberido elBoberido deleted the iox-#1283-backports-commits-from-release_2.0-branch-to-master branch March 14, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Porting a fix or feature between branches
Projects
None yet
7 participants