Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binding_c needs "proper" prototypes #1280

Closed
eboasson opened this issue Mar 11, 2022 · 0 comments · Fixed by #1281 or #1285
Closed

binding_c needs "proper" prototypes #1280

eboasson opened this issue Mar 11, 2022 · 0 comments · Fixed by #1281 or #1285

Comments

@eboasson
Copy link
Contributor

Required information

Operating system:
E.g. maxOS 12.2.1

Compiler version:
E.g. Apple clang version 13.0.0 (clang-1300.0.29.30)

Observed result or behaviour:
Compiler warnings when compiling Cyclone DDS with Iceoryx 2.0 branch:

/Users/erik/C/iceoryx/install/include/iceoryx/v1.91.0/iceoryx_binding_c/config.h:23:32: warning: this function declaration is not a prototype [-Wstrict-prototypes]
uint32_t iox_cfg_max_publishers();
                               ^
                                void

Expected result or behaviour:
No warnings

Conditions where it occurred / Performed steps:
Build Cyclone DDS including eclipse-cyclonedds/cyclonedds#1175 with default compilation setting on aforementioned platform.

eboasson added a commit to eboasson/iceoryx that referenced this issue Mar 11, 2022
Declaring a function in C that takes no argument requires "(void)".
With strict warning settings, C compilers will issue a warning.

Signed-off-by: Erik Boasson <eb@ilities.com>
MatthiasKillat added a commit that referenced this issue Mar 11, 2022
…-config-h

iox-#1280 use proper prototypes in C binding
@elBoberido elBoberido linked a pull request Mar 11, 2022 that will close this issue
21 tasks
@elBoberido elBoberido linked a pull request Mar 11, 2022 that will close this issue
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant