Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #1126 add replace conflicts tag hoofs package #1275

Conversation

dkroenke
Copy link
Member

@dkroenke dkroenke commented Mar 10, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

Adding tags to package xml in hoofs for potential conflicts with the old utils package.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
@dkroenke dkroenke added the tooling All iceoryx related tooling (scripts etc.) label Mar 10, 2022
@dkroenke dkroenke self-assigned this Mar 10, 2022
@dkroenke dkroenke changed the base branch from master to release_2.0 March 10, 2022 19:04
@dkroenke dkroenke marked this pull request as ready for review March 11, 2022 14:35
@dkroenke dkroenke merged commit f030ed9 into eclipse-iceoryx:release_2.0 Mar 11, 2022
@dkroenke dkroenke deleted the iox-#1126-add-replace-conflicts-tag-hoofs-package branch March 11, 2022 14:36
@elBoberido elBoberido linked an issue Mar 11, 2022 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iceoryx 2.0 release
3 participants