Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HandleTranslator in Windows must be thread safe #1264

Closed
elfenpiff opened this issue Mar 9, 2022 · 2 comments · Fixed by #1266 or #1285
Closed

HandleTranslator in Windows must be thread safe #1264

elfenpiff opened this issue Mar 9, 2022 · 2 comments · Fixed by #1266 or #1285
Assignees
@elfenpiff
Milestone
High prio

Comments

@elfenpiff
Copy link
Contributor

Required information

Operating system:
Windows

Compiler version:
Every compiler

Observed result or behaviour:
Spurious failures in the CI and in Windows can be caused by opening/closes constructs concurrently which are using underlying file handles.
Normally, one can open files concurrently without problem but in windows the HandleTranslator is used to provide an uniform access to file handles. This construct is not threadsafe - this has to be changed.
elfenpiff added a commit that referenced this issue Mar 9, 2022
@elfenpiff
iox-#1264 make handle translator threadsafe
376f5c3 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit that referenced this issue Mar 9, 2022
@elfenpiff
iox-#1264 Enable some tests and fix PoshRuntime_test.NoAppName
dd03009 
Signed-off-by: Christian Eltzschig <me@elchris.org>
@elfenpiff elfenpiff mentioned this issue Mar 9, 2022
Merged
21 tasks
elfenpiff added a commit that referenced this issue Mar 9, 2022
@elfenpiff
iox-#1264 Fix copyright year
3bd9eb7 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit that referenced this issue Mar 10, 2022
@elfenpiff
Merge pull request #1266 from eclipse-iceoryx/iox-#1264-threadsafe-ha…
8628307 
…ndle-translator-for-windows

Iox #1264 threadsafe handle translator for windows
@elfenpiff elfenpiff self-assigned this Mar 10, 2022
@elfenpiff elfenpiff added this to the High prio milestone Mar 10, 2022
@elBoberido
Copy link
Member

can this be closed?

@elfenpiff
Copy link
Contributor Author

It is only merged to the release branch and not to the master branch which is as well affected. Should we keep this open until release_2.0 is merged to master @dkroenke ?

elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 10, 2022
@elfenpiff
iox-eclipse-iceoryx#1264 update changelog
202025f 
Signed-off-by: Christian Eltzschig <me@elchris.org>
@elfenpiff elfenpiff mentioned this issue Mar 10, 2022
Merged
21 tasks
@elBoberido elBoberido linked a pull request Mar 11, 2022 that will close this issue
Iox #1264 threadsafe handle translator for windows #1266
Merged
21 tasks
This was referenced Mar 11, 2022
Closed
Merged
@elBoberido elBoberido linked a pull request Mar 11, 2022 that will close this issue
Iox #1283 backports commits from release 2.0 branch to master #1285
Merged
21 tasks
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 18, 2022
@elfenpiff
iox-eclipse-iceoryx#1264 Script cleanup, exclude .git directory from …
6c6b5cf 
…markdown checks

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 18, 2022
@elfenpiff
iox-eclipse-iceoryx#1264 Adjust local links
4489613 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 18, 2022
@elfenpiff
iox-eclipse-iceoryx#1264 Script cleanup, exclude .git directory from …
61717b2 
…markdown checks

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 18, 2022
@elfenpiff
iox-eclipse-iceoryx#1264 Adjust local links
80c5a7e 
Signed-off-by: Christian Eltzschig <me@elchris.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elfenpiff elfenpiff

Labels
None yet
Projects
None yet
Milestone
High prio
2 participants
@elfenpiff @elBoberido