Skip to content

Commit

Permalink
iox-#1264 Enable some tests and fix PoshRuntime_test.NoAppName
Browse files Browse the repository at this point in the history
Signed-off-by: Christian Eltzschig <me@elchris.org>
  • Loading branch information
elfenpiff committed Mar 9, 2022
1 parent 376f5c3 commit dd03009
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions iceoryx_posh/test/moduletests/test_posh_runtime.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,7 @@ TEST_F(PoshRuntime_test, NoAppName)
::testing::Test::RecordProperty("TEST_ID", "e053d114-c79c-4391-91e1-8fcfe90ee8e4");
const iox::RuntimeName_t invalidAppName("");

EXPECT_DEATH({ PoshRuntime::initRuntime(invalidAppName); },
"Cannot initialize runtime. Application name must not be empty!");
EXPECT_DEATH({ PoshRuntime::initRuntime(invalidAppName); }, "");
}

// To be able to test the singleton and avoid return the exisiting instance, we don't use the test fixture
Expand Down
2 changes: 1 addition & 1 deletion tools/ci/build-test-windows.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ if ($?) { Write-Host "running tests (excluding timing_tests)" }
if ($?) { build\hoofs\test\Debug\hoofs_moduletests.exe --gtest_filter="-SharedMemory_Test.CreateOrOpenCreatesShmWhenShmDoesNotExist:SharedMemory_Test.OpenFailsWhenShmDoesNotExist:*TimingTest*" }
if ($?) { build\hoofs\test\Debug\hoofs_integrationtests.exe }
if ($?) { build\binding_c\test\Debug\binding_c_moduletests.exe --gtest_filter="-BindingC_Runtime_test.RuntimeNameLengthIsOutOfLimit:BindingC_Runtime_test.RuntimeNameIsNullptr:*TimingTest*" }
if ($?) { build\posh\test\Debug\posh_moduletests.exe --gtest_filter="-ChunkHeader_test.ChunkHeaderBinaryCompatibilityCheck:TomlGatewayConfigParserSuiteTest*:IceoryxRoudiApp_test*:PoshRuntime_test.NoAppName:ValidTest*:ParseAllMalformedInput*:*TimingTest*" }
if ($?) { build\posh\test\Debug\posh_moduletests.exe --gtest_filter="-ChunkHeader_test.ChunkHeaderBinaryCompatibilityCheck:TomlGatewayConfigParserSuiteTest*:IceoryxRoudiApp_test.ConstructorCalledWithArgUniqueIdTwoTimesReturnError:IceoryxRoudiApp_test.ConstructorCalledWithArgVersionSetRunVariableToFalse:ValidTest*:ParseAllMalformedInput*:*TimingTest*" }
if ($?) { build\posh\test\Debug\posh_integrationtests.exe --gtest_filter="-ChunkBuildingBlocks_IntegrationTest.TwoHopsThreeThreadsNoSoFi:*TimingTest*" }

exit $LASTEXITCODE

0 comments on commit dd03009

Please sign in to comment.