Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#743 Review Governance #1259

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Mar 9, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Signed-off-by: Christian Eltzschig <me@elchris.org>
@elfenpiff elfenpiff changed the title iox-#743 Fix typo iox-#743 Review Governance Mar 9, 2022
@elfenpiff elfenpiff self-assigned this Mar 9, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #1259 (a9a38d2) into release_2.0 (829f190) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release_2.0    #1259      +/-   ##
===============================================
- Coverage        78.94%   78.92%   -0.03%     
===============================================
  Files              370      370              
  Lines            14706    14706              
  Branches          2059     2059              
===============================================
- Hits             11610    11606       -4     
- Misses            2416     2418       +2     
- Partials           680      682       +2     
Flag Coverage Δ
unittests 78.15% <ø> (-0.02%) ⬇️
unittests_timing 15.48% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_posh/source/mepoo/shared_chunk.cpp 93.33% <0.00%> (-3.34%) ⬇️
iceoryx_hoofs/source/posix_wrapper/timer.cpp 63.07% <0.00%> (-0.83%) ⬇️

@elfenpiff elfenpiff merged commit e5a8663 into eclipse-iceoryx:release_2.0 Mar 9, 2022
@elfenpiff elfenpiff deleted the iox-#743-review-governance branch March 9, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants