Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forward and back buttons to organize column search #1529

Closed
dsmmcken opened this issue Sep 20, 2023 · 0 comments · Fixed by #1620, #1641, deephaven/deephaven-core#4864 or deephaven/deephaven-core#4930
Closed

Add forward and back buttons to organize column search #1529

dsmmcken opened this issue Sep 20, 2023 · 0 comments · Fixed by #1620, #1641, deephaven/deephaven-core#4864 or deephaven/deephaven-core#4930
Assignees
@ethanalvizo
Labels
enhancement New feature or request

Comments

@dsmmcken
Copy link
Contributor

  • Initial search should still select all items, and scroll into view the first item.
  • Pressing left/right arrow should scroll into view the previous/next item, and select just that item. Show N of M for indicator
  • Navigation should loop, pressing previous on first should go to last item and vice versa.

Note make sure padding is increased on the input when the buttons appear, so that it doesn't overlap the search text.

image
@dsmmcken dsmmcken added enhancement New feature or request triage Issue requires triage labels Sep 20, 2023
@vbabich vbabich added this to the October 2023 milestone Sep 26, 2023
@vbabich vbabich removed the triage Issue requires triage label Sep 26, 2023
@ethanalvizo ethanalvizo self-assigned this Oct 23, 2023
@ethanalvizo ethanalvizo mentioned this issue Nov 3, 2023
Merged
ethanalvizo added a commit that referenced this issue Nov 14, 2023
@ethanalvizo
feat: forward and back buttons for organize column search (#1620)
75cf184 
Closes #1529
@ethanalvizo ethanalvizo mentioned this issue Nov 14, 2023
Merged
@mofojed mofojed mentioned this issue Nov 21, 2023
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Nov 21, 2023
@github-actions @deephaven-internal
Update web version 0.55.0 (#4864)
0de9de8 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.55.0

# [0.55.0](deephaven/web-client-ui@v0.54.0...v0.55.0) (2023-11-20)


### Bug Fixes

* Changes for Deephaven UI embedding widget plugins ([#1644](deephaven/web-client-ui#1644)) ([b6eeb30](deephaven/web-client-ui@b6eeb30))
* Fixed chart e2e test changing daily ([#1652](deephaven/web-client-ui#1652)) ([f9f62db](deephaven/web-client-ui@f9f62db)), closes [#1634](deephaven/web-client-ui#1634)
* Isolate Styleguide snapshots ([#1649](deephaven/web-client-ui#1649)) ([a2ef056](deephaven/web-client-ui@a2ef056))


### Features

* forward and back buttons for organize column search ([#1620](deephaven/web-client-ui#1620)) ([75cf184](deephaven/web-client-ui@75cf184)), closes [#1529](deephaven/web-client-ui#1529)
* Styleguide regression tests ([#1639](deephaven/web-client-ui#1639)) ([561ff22](deephaven/web-client-ui@561ff22)), closes [#1634](deephaven/web-client-ui#1634)


### Reverts

* feat: forward and back buttons for organize column search ([#1640](deephaven/web-client-ui#1640)) ([737d1aa](deephaven/web-client-ui@737d1aa))

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
ethanalvizo added a commit that referenced this issue Nov 27, 2023
@ethanalvizo
feat: forward and back button for organize column search (#1641)
89f2be5 
Closes #1529
@mofojed mofojed mentioned this issue Dec 11, 2023
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Dec 11, 2023
@github-actions @deephaven-internal
Update web version 0.56.0 (#4930)
c29aaf8 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.56.0

# [0.56.0](deephaven/web-client-ui@v0.55.0...v0.56.0) (2023-12-11)


### Bug Fixes

* add right margin to <Button kind='inline'/> using icons ([#1664](deephaven/web-client-ui#1664)) ([fd8a6c6](deephaven/web-client-ui@fd8a6c6))
* adjust filter bar colour ([#1666](deephaven/web-client-ui#1666)) ([4c0200e](deephaven/web-client-ui@4c0200e))
* convert organize columns component to purecomponent ([#1653](deephaven/web-client-ui#1653)) ([8ddc114](deephaven/web-client-ui@8ddc114)), closes [#1650](deephaven/web-client-ui#1650)
* Default to `Skip` operation instead of `Sum` operation ([#1648](deephaven/web-client-ui#1648)) ([6083173](deephaven/web-client-ui@6083173)), closes [#1355](deephaven/web-client-ui#1355) [#1355](deephaven/web-client-ui#1355)
* Fix button snapshots ([#1655](deephaven/web-client-ui#1655)) ([c0cc966](deephaven/web-client-ui@c0cc966))
* popper blur in styleguide ([#1672](deephaven/web-client-ui#1672)) ([6fa2204](deephaven/web-client-ui@6fa2204))
* Unable to delete selected rows in some input tables ([#1678](deephaven/web-client-ui#1678)) ([1e71550](deephaven/web-client-ui@1e71550)), closes [#1677](deephaven/web-client-ui#1677)


### Features

* Add embed-widget ([#1668](deephaven/web-client-ui#1668)) ([1b06675](deephaven/web-client-ui@1b06675)), closes [#1629](deephaven/web-client-ui#1629)
* forward and back button for organize column search ([#1641](deephaven/web-client-ui#1641)) ([89f2be5](deephaven/web-client-ui@89f2be5)), closes [#1529](deephaven/web-client-ui#1529)
* Tables that have names starting with underscore do not auto-launch from console ([#1656](deephaven/web-client-ui#1656)) ([21131fe](deephaven/web-client-ui@21131fe)), closes [#1549](deephaven/web-client-ui#1549) [#1410](deephaven/web-client-ui#1410)
* theme fontawesome icon size wrapped in spectrum icons ([#1658](deephaven/web-client-ui#1658)) ([2aa8cef](deephaven/web-client-ui@2aa8cef))
* Theme Selector ([#1661](deephaven/web-client-ui#1661)) ([5e2be64](deephaven/web-client-ui@5e2be64)), closes [#1660](deephaven/web-client-ui#1660)
* Theming - Bootstrap ([#1603](deephaven/web-client-ui#1603)) ([88bcae0](deephaven/web-client-ui@88bcae0))
* Theming - Inline svgs ([#1651](deephaven/web-client-ui#1651)) ([1e40d3e](deephaven/web-client-ui@1e40d3e))
* View cell contents in context menu ([#1657](deephaven/web-client-ui#1657)) ([90b7517](deephaven/web-client-ui@90b7517)), closes [#1605](deephaven/web-client-ui#1605)


### BREAKING CHANGES

* Bootstrap color variables are now predominantly hsl based. SCSS will need to be updated accordingly. Theme providers are needed to load themes.
* Tables assigned to variable beginning with "_" will not open automatically even if "Auto Launch Panels" is checked.

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanalvizo ethanalvizo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@dsmmcken @vbabich @ethanalvizo