Ensure the wrong number of parameters in a call to deephaven.ParquetTools.writeTable generates an error. #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ools.writeTable generates an error.
jmao-denver
previously approved these changes
Dec 7, 2021
jmao-denver
approved these changes
Dec 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is right now, and due to a mistake in an earlier change on that file, a call to
deephaven.ParquetTools.writeTablewith the wrong number of parameters (eg, 1, like just the filename or just the table name), silently does nothing instead of alerting the userthat something is wrong; this was not intentional and is misleading, eg, a user can mistake the (wrongful) no output for success.
I noticed this recently after having fell myself to that trap in some debugging session: I forgot one argument and for a while couldn't understand what was going on when the file was not showing up.