Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changes for Deephaven UI embedding widget plugins #1644

Merged
merged 7 commits into from
Nov 20, 2023

Conversation

mattrunyon
Copy link
Collaborator

These changes are needed so Deephaven UI can embed widget plugins. This also creates a difference between the widget component and the widget panel component.

Will open a companion UI plugin PR to utilize these in Deephaven UI.

Tested the panels still function as intended for grid, chart, and dataframe.

@mattrunyon mattrunyon self-assigned this Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (f9f62db) 46.65% compared to head (ce9cb4f) 46.57%.

❗ Current head ce9cb4f differs from pull request most recent head 7e0a67b. Consider uploading reports for the commit 7e0a67b to get more accurate results

Files Patch % Lines
.../dashboard-core-plugins/src/PandasWidgetPlugin.tsx 0.00% 29 Missing ⚠️
...s/dashboard-core-plugins/src/ChartWidgetPlugin.tsx 0.00% 16 Missing ⚠️
...es/dashboard-core-plugins/src/GridWidgetPlugin.tsx 0.00% 15 Missing ⚠️
...ard-core-plugins/src/panels/PandasReloadButton.tsx 0.00% 7 Missing ⚠️
...s/dashboard-core-plugins/src/PandasPanelPlugin.tsx 33.33% 4 Missing ⚠️
packages/chart/src/Chart.tsx 0.00% 1 Missing ⚠️
...es/dashboard-core-plugins/src/ChartPanelPlugin.tsx 66.66% 1 Missing ⚠️
...ges/dashboard-core-plugins/src/GridPanelPlugin.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1644      +/-   ##
==========================================
- Coverage   46.65%   46.57%   -0.09%     
==========================================
  Files         593      597       +4     
  Lines       36467    36531      +64     
  Branches     9135     9142       +7     
==========================================
  Hits        17014    17014              
- Misses      19401    19465      +64     
  Partials       52       52              
Flag Coverage Δ
unit 46.57% <8.64%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattrunyon mattrunyon merged commit b6eeb30 into deephaven:main Nov 20, 2023
4 checks passed
@mattrunyon mattrunyon deleted the ui-widget-plugins branch November 20, 2023 17:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants