Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generation of JSON python doc has a problem in arguments that result in text including 'extends'. #1639

Closed
jcferretti opened this issue Dec 6, 2021 · 1 comment
Closed

Generation of JSON python doc has a problem in arguments that result in text including 'extends'. #1639

jcferretti opened this issue Dec 6, 2021 · 1 comment
Assignees
@niloc132 @chipkent
Labels
bug Something isn't working triage
Milestone
Backlog

Comments

@jcferretti
Copy link
Member

Like so:

cfs@erke 19:11:29 ~/dh/oss3/deephaven-core
$ find Integrations/python/deephaven/doc -name '*.json' | xargs grep 'extends[^ ]' | head -n 1
Integrations/python/deephaven/doc/io/deephaven/parquet/table/metadata/TableInfo/Builder.json:  "addAllColumnTypes": ":param columnTypes: java.lang.Iterable<? extendsio.deephaven.parquet.table.metadata.ColumnTypeInfo>\n:return: io.deephaven.parquet.table.metadata.TableInfo.Builder",

Note above there is a missing space between extends and io.deephaven...
@jcferretti jcferretti added bug Something isn't working triage labels Dec 6, 2021
@jcferretti jcferretti added this to the Dec 2021 milestone Dec 6, 2021
@pete-petey pete-petey modified the milestones: Dec 2021, Backlog Dec 29, 2021
@niloc132
Copy link
Member

Closing as won't fix, javadoc->json->py gen is removed.

@niloc132 niloc132 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2022
mofojed pushed a commit that referenced this issue Nov 21, 2023
@github-actions @deephaven-internal
Update web version 0.55.0 (#4864)
0de9de8 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.55.0

# [0.55.0](deephaven/web-client-ui@v0.54.0...v0.55.0) (2023-11-20)


### Bug Fixes

* Changes for Deephaven UI embedding widget plugins ([#1644](deephaven/web-client-ui#1644)) ([b6eeb30](deephaven/web-client-ui@b6eeb30))
* Fixed chart e2e test changing daily ([#1652](deephaven/web-client-ui#1652)) ([f9f62db](deephaven/web-client-ui@f9f62db)), closes [#1634](deephaven/web-client-ui#1634)
* Isolate Styleguide snapshots ([#1649](deephaven/web-client-ui#1649)) ([a2ef056](deephaven/web-client-ui@a2ef056))


### Features

* forward and back buttons for organize column search ([#1620](deephaven/web-client-ui#1620)) ([75cf184](deephaven/web-client-ui@75cf184)), closes [#1529](deephaven/web-client-ui#1529)
* Styleguide regression tests ([#1639](deephaven/web-client-ui#1639)) ([561ff22](deephaven/web-client-ui@561ff22)), closes [#1634](deephaven/web-client-ui#1634)


### Reverts

* feat: forward and back buttons for organize column search ([#1640](deephaven/web-client-ui#1640)) ([737d1aa](deephaven/web-client-ui@737d1aa))

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloc132 niloc132

@chipkent chipkent

Labels
bug Something isn't working triage
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@niloc132 @chipkent @jcferretti @pete-petey