-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theming - Inline svgs need to support dynamic css prop colors #1634
Closed
bmingles opened this issue
Nov 10, 2023
· 0 comments
· Fixed by #1639, #1652 or deephaven/deephaven-core#4864
Closed
Theming - Inline svgs need to support dynamic css prop colors #1634
bmingles opened this issue
Nov 10, 2023
· 0 comments
· Fixed by #1639, #1652 or deephaven/deephaven-core#4864
Labels
Comments
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 13, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 13, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 13, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 13, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
- Explicit grid font - Longer scroll delay - Exclude disabled btn + input from state tests deephaven#1634
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 14, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 22, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 27, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 27, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 27, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use inline svgs for certain icons. In some cases these are created via string concatenation with a Bootstrap color variable which is available at compile time. This does not work with dynamic CSS custom props which can change at runtime. We need to adjust this approach to support dynamic variables for theming.
It should be possible to address some of these using svg masks, but others will likely require a .js based option to dynamically update svgs when themes change (should be able to store the svgs in css props and update them, but need to test this)
The text was updated successfully, but these errors were encountered: