Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming - Inline svgs need to support dynamic css prop colors #1634

Closed
bmingles opened this issue Nov 10, 2023 · 0 comments · Fixed by #1639, #1652 or deephaven/deephaven-core#4864
Closed

Theming - Inline svgs need to support dynamic css prop colors #1634

bmingles opened this issue Nov 10, 2023 · 0 comments · Fixed by #1639, #1652 or deephaven/deephaven-core#4864
Assignees
@bmingles
Labels
enhancement New feature or request web-client-ui

Comments

@bmingles
Copy link
Contributor

We use inline svgs for certain icons. In some cases these are created via string concatenation with a Bootstrap color variable which is available at compile time. This does not work with dynamic CSS custom props which can change at runtime. We need to adjust this approach to support dynamic variables for theming.

  • Golden layout icons (e.g. .lm_maximise)
  • Form validation icons
  • Select input arrows

It should be possible to address some of these using svg masks, but others will likely require a .js based option to dynamically update svgs when themes change (should be able to store the svgs in css props and update them, but need to test this)
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Nov 10, 2023
@bmingles bmingles self-assigned this Nov 10, 2023
@bmingles bmingles added web-client-ui and removed triage Issue requires triage labels Nov 10, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 13, 2023
@bmingles
Added styleguide as sub route to ide
3fb3ae6 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 13, 2023
@bmingles
Styleguide regression tests
de55ab2 
deephaven#1634
@bmingles bmingles mentioned this issue Nov 13, 2023
Merged
@bmingles bmingles linked a pull request Nov 13, 2023 that will close this issue
feat: Styleguide regression tests #1639
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 13, 2023
@bmingles
Seeded random number generator
ef690fe 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 13, 2023
@bmingles
Reorganized screenshots
4492599 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Button + input state tests
36b9f0b 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Added styleguide as sub route to ide
5200f59 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Styleguide regression tests
bcce990 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Seeded random number generator
570996d 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Reorganized screenshots
8b43472 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Button + input state tests
2abd376 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Fixed e2e tests
be26e74 
- Explicit grid font
- Longer scroll delay
- Exclude disabled btn + input from state tests

deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Reverted grid theme and fixed util warning
44dc09c 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Updated snapshots
d790936 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Font family changes
fe2dc1a 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Added missing trailing slash
22b8b9f 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Reverted font and fixed sample scrolling
4a2e627 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Setting locale in Docker
8906f1b 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Reverted locale changes
729600c 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Styleguide menus parent no longer spans width
e5a25a5 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Updated snapshots
3799e1b 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Fixed flex issue in grid samples
5031ba2 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Output Playwright version
6d10a74 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 14, 2023
@bmingles
Log browser info
88fc8df 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Time select icon
72a40c0 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Updated e2e snapshots
8201058 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Split out mixin into utils
b18a5de 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Custom select caret + semantics
47b458b 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Custom time select caret
f31a76c 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Combobox caret
3579b1d 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Removed unnecessary styles
dc01784 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Updated e2e snapshots
4d63f36 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Fixed Firefox caret size
4831e8c 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Mozilla disabled style
5e2c358 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Added disabled / invalid states to styleguide
6bd24f5 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Unit tests
bd078fc 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Fixed reversed icons + tests
9797342 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Fixed mimimised icon
3369462 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Update snapshots
abab14a 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Update snapshots
00bb7b7 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Test coverage
636207c 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Moved scss util and fixed css warning
49e623b 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Added comment
0eeb9e2 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Comments
a164b70 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Fixing failed e2e tests
dd34f09 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Switched to test context
293d4bf 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Fixed beforeAll
70a0d5c 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Trying waitForSelector
fc60f4f 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Trying not count
b70091a 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 22, 2023
@bmingles
Page reload
21ea1d8 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 27, 2023
@bmingles
Move e2e tests out of loop
893c7e5 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 27, 2023
@bmingles
Updated test count
43c2f11 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 27, 2023
@bmingles
Updated snapshot
13663d9 
deephaven#1634
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 30, 2023
@bmingles
Moved styleguide color utils
5e7846b 
deephaven#1634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request web-client-ui
Projects
None yet
Milestone
No milestone
1 participant
@bmingles