Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming - Theme selector #1660

Closed
bmingles opened this issue Nov 28, 2023 · 0 comments · Fixed by #1661 or deephaven/deephaven-core#4930
Closed

Theming - Theme selector #1660

bmingles opened this issue Nov 28, 2023 · 0 comments · Fixed by #1661 or deephaven/deephaven-core#4930
Assignees
@bmingles
Labels
enhancement New feature or request web-client-ui

Comments

@bmingles
Copy link
Contributor

bmingles commented Nov 28, 2023 •
edited
Loading

We need to add a theme selector to the settings menu.

  • Should show all themes available from default or plugins
  • Should change theme realtime when selection changes
  • For now we can hide it if only 1 theme is available. We can then easily enable during dev by adding plugins and keep it hidden from users while we still work through remaining theme support

DH-16020 will implement in DHE

See Don's POC for starting point
https://github.com/deephaven/web-client-ui/pull/1460/files#diff-d0402466d6aa89364526f1efba471ff5eb597b40ed81273323a5dc6c73137a89
@bmingles bmingles added enhancement New feature or request web-client-ui labels Nov 28, 2023
@bmingles bmingles self-assigned this Nov 28, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 29, 2023
@bmingles
Moved getThemeDataFromPlugins
883bb70 
deephaven#1660
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 29, 2023
@bmingles
Added theme picker to styleguide
1120f3e 
deephaven#1660
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 29, 2023
@bmingles
Added ThemePicker to SettingsMenu
5629c4a 
deephaven#1660
@bmingles bmingles mentioned this issue Nov 29, 2023
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 29, 2023
@bmingles
Support local vite config
7bd6ade 
deephaven#1660
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 29, 2023
@bmingles
Refresh irisgrid and monaco on theme change
0773b57 
deephaven#1660
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 29, 2023
@bmingles
Removed unnecessary providers
a6eb952 
deephaven#1660
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 30, 2023
@bmingles
Fixed failing tests
b74a4f5 
deephaven#1660
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 30, 2023
@bmingles
Env config for local plugin dev
3f9897a 
deephaven#1660
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 30, 2023
@bmingles
Updated package lock
a8b3a4a 
deephaven#1660
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 30, 2023
@bmingles
Initialize Monaco theme as part of init
2fd804c 
deephaven#1660
bmingles added a commit to bmingles/web-client-ui that referenced this issue Dec 6, 2023
@bmingles
Code review changes
9f4f3aa 
deephaven#1660
bmingles added a commit to bmingles/web-client-ui that referenced this issue Dec 6, 2023
@bmingles
Fixed README
a4597dc 
deephaven#1660
bmingles added a commit that referenced this issue Dec 6, 2023
@bmingles
feat: Theme Selector (#1661)
5e2be64 
- Added a theme selector to settings menu when there are multiple themes
available
- IrisGrid and Monaco now respond dynamically to selected theme change
- Misc moving of theme utils
- Added vite config for local plugin dev

resolves #1660
@mofojed mofojed mentioned this issue Dec 11, 2023
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Dec 11, 2023
@github-actions @deephaven-internal
Update web version 0.56.0 (#4930)
c29aaf8 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.56.0

# [0.56.0](deephaven/web-client-ui@v0.55.0...v0.56.0) (2023-12-11)


### Bug Fixes

* add right margin to <Button kind='inline'/> using icons ([#1664](deephaven/web-client-ui#1664)) ([fd8a6c6](deephaven/web-client-ui@fd8a6c6))
* adjust filter bar colour ([#1666](deephaven/web-client-ui#1666)) ([4c0200e](deephaven/web-client-ui@4c0200e))
* convert organize columns component to purecomponent ([#1653](deephaven/web-client-ui#1653)) ([8ddc114](deephaven/web-client-ui@8ddc114)), closes [#1650](deephaven/web-client-ui#1650)
* Default to `Skip` operation instead of `Sum` operation ([#1648](deephaven/web-client-ui#1648)) ([6083173](deephaven/web-client-ui@6083173)), closes [#1355](deephaven/web-client-ui#1355) [#1355](deephaven/web-client-ui#1355)
* Fix button snapshots ([#1655](deephaven/web-client-ui#1655)) ([c0cc966](deephaven/web-client-ui@c0cc966))
* popper blur in styleguide ([#1672](deephaven/web-client-ui#1672)) ([6fa2204](deephaven/web-client-ui@6fa2204))
* Unable to delete selected rows in some input tables ([#1678](deephaven/web-client-ui#1678)) ([1e71550](deephaven/web-client-ui@1e71550)), closes [#1677](deephaven/web-client-ui#1677)


### Features

* Add embed-widget ([#1668](deephaven/web-client-ui#1668)) ([1b06675](deephaven/web-client-ui@1b06675)), closes [#1629](deephaven/web-client-ui#1629)
* forward and back button for organize column search ([#1641](deephaven/web-client-ui#1641)) ([89f2be5](deephaven/web-client-ui@89f2be5)), closes [#1529](deephaven/web-client-ui#1529)
* Tables that have names starting with underscore do not auto-launch from console ([#1656](deephaven/web-client-ui#1656)) ([21131fe](deephaven/web-client-ui@21131fe)), closes [#1549](deephaven/web-client-ui#1549) [#1410](deephaven/web-client-ui#1410)
* theme fontawesome icon size wrapped in spectrum icons ([#1658](deephaven/web-client-ui#1658)) ([2aa8cef](deephaven/web-client-ui@2aa8cef))
* Theme Selector ([#1661](deephaven/web-client-ui#1661)) ([5e2be64](deephaven/web-client-ui@5e2be64)), closes [#1660](deephaven/web-client-ui#1660)
* Theming - Bootstrap ([#1603](deephaven/web-client-ui#1603)) ([88bcae0](deephaven/web-client-ui@88bcae0))
* Theming - Inline svgs ([#1651](deephaven/web-client-ui#1651)) ([1e40d3e](deephaven/web-client-ui@1e40d3e))
* View cell contents in context menu ([#1657](deephaven/web-client-ui#1657)) ([90b7517](deephaven/web-client-ui@90b7517)), closes [#1605](deephaven/web-client-ui#1605)


### BREAKING CHANGES

* Bootstrap color variables are now predominantly hsl based. SCSS will need to be updated accordingly. Theme providers are needed to load themes.
* Tables assigned to variable beginning with "_" will not open automatically even if "Auto Launch Panels" is checked.

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request web-client-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Theme Selector bmingles/web-client-ui
Update web version 0.56.0 deephaven/deephaven-core
1 participant
@bmingles