Implementation of the Muon Track Splitting (MTS) Validation in the new TkAl all-in-one tool #43708

mmusich · 2024-01-12T19:37:38Z

PR description:

This PR is a first attempt to integrate the Muon Track Splitting (a.k.a. MTS) tool in the new Tracker alignment all-in-one tool (introduced at #38304), as a follow-up to #43386 which removed the old (and unusable) configuration.
This PR builds on top of the previous internal PR at cms-trackeralign#31 and adds:

merge step for MTS validation;
implement MTS validation in unit tests;
update README for Muon Track Splitting;
finally it applies code check and code format standards;

PR validation:

cmssw compiles
scam b runtests_MTSall runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not to be backported.

cmsbuild · 2024-01-12T19:38:05Z

cms-bot internal usage

cmsbuild · 2024-01-12T19:49:54Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43708/38398

This PR adds an extra 64KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43708/38398/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43708/38398/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-01-12T20:04:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43708/38400

This PR adds an extra 60KB to repository

cmsbuild · 2024-01-12T20:04:43Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/OfflineValidation (alca)

@cmsbuild, @saumyaphor4252, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@adewit, @tlampen, @mmusich, @rsreds, @yuanchao, @tocheng this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

mmusich · 2024-01-12T20:04:56Z

@cmsbuild, please test

cmsbuild · 2024-01-13T01:46:39Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cacdfb/36814/summary.html
COMMIT: 5f99680
CMSSW: CMSSW_14_0_X_2024-01-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43708/36814/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cacdfb/36814/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cacdfb/36814/git-merge-result

Unit Tests

I found 7 errors in the following unit tests:

---> test SplitVall had ERRORS
---> test DMRall had ERRORS
---> test DiMuonVall had ERRORS
and more ...

Comparison Summary

Summary:

You potentially removed 15 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 405 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3247277
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3247252
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 40.564999999999976 KiB( 47 files compared)
DQMHistoSizes: changed ( 1000.0,... ): 1.266 KiB Tracking/ShortTrackResolution
DQMHistoSizes: changed ( 11634.0,... ): 0.426 KiB Physics/NanoAODDQM
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

…l-in-one tool: - code-checks & code-format - fix deleteCanvas and code-format

cmsbuild · 2024-01-14T18:00:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43708/38401

This PR adds an extra 64KB to repository

cmsbuild · 2024-01-14T18:01:20Z

Pull request #43708 was updated. @cmsbuild, @perrotta, @saumyaphor4252, @consuegs can you please check and sign again.

mmusich · 2024-01-14T19:07:55Z

@cmsbuild, please test

cmsbuild · 2024-01-14T22:05:45Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cacdfb/36815/summary.html
COMMIT: 9b5497d
CMSSW: CMSSW_14_0_X_2024-01-14-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43708/36815/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 103 lines from the logs
Reco comparison results: 29 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3247454
DQMHistoTests: Total failures: 1225
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3246207
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

perrotta · 2024-01-15T10:14:22Z

+1

Unit tests succeed

cmsbuild · 2024-01-15T10:14:47Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2024-01-15T16:01:35Z

+1

cmsbuild added this to the CMSSW_14_0_X milestone Jan 12, 2024

cmsbuild added alca-pending pending-signatures tests-pending orp-pending code-checks-pending trk labels Jan 12, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 12, 2024

mmusich force-pushed the mm_dev_MTS_implementation_all_in_one_14_0_X branch from db560d2 to 5f99680 Compare January 12, 2024 19:57

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 12, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 12, 2024

cmsbuild added tests-started and removed tests-pending labels Jan 12, 2024

cmsbuild added tests-rejected and removed tests-started labels Jan 13, 2024

federicovazzoler and others added 6 commits January 14, 2024 18:52

First implementation of Muon Track Splitting validation in the new al…

76f11ab

…l-in-one tool: - code-checks & code-format - fix deleteCanvas and code-format

implement merge step for MTS validation

f84625c

implement MTS validation in all-in-one unit tests

4feac71

fix typo in test_unitDiMuonV

7557c51

update README for Muon Track Splitting

b842705

apply code-checks and code-format to trackSplitPlot.C

9b5497d

mmusich force-pushed the mm_dev_MTS_implementation_all_in_one_14_0_X branch from 5f99680 to 9b5497d Compare January 14, 2024 17:53

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Jan 14, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 14, 2024

cmsbuild added tests-started and removed tests-pending labels Jan 14, 2024

cmsbuild added tests-approved and removed tests-started labels Jan 14, 2024

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jan 15, 2024

cmsbuild added orp-approved and removed orp-pending labels Jan 15, 2024

cmsbuild merged commit 1510f7f into cms-sw:master Jan 15, 2024
11 checks passed

mmusich deleted the mm_dev_MTS_implementation_all_in_one_14_0_X branch January 15, 2024 16:02

This was referenced Jan 15, 2024

PGO: Use env variables with fprofile-use instead of %q{VAR} cms-sw/cmsdist#8939

Merged

Update testTrackAnalyzers #43716

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of the Muon Track Splitting (MTS) Validation in the new TkAl all-in-one tool #43708

Implementation of the Muon Track Splitting (MTS) Validation in the new TkAl all-in-one tool #43708

mmusich commented Jan 12, 2024 •

edited

Loading

cmsbuild commented Jan 12, 2024 •

edited

Loading

cmsbuild commented Jan 12, 2024

cmsbuild commented Jan 12, 2024

cmsbuild commented Jan 12, 2024

mmusich commented Jan 12, 2024

cmsbuild commented Jan 13, 2024

cmsbuild commented Jan 14, 2024

cmsbuild commented Jan 14, 2024

mmusich commented Jan 14, 2024

cmsbuild commented Jan 14, 2024

perrotta commented Jan 15, 2024

cmsbuild commented Jan 15, 2024

rappoccio commented Jan 15, 2024

Implementation of the Muon Track Splitting (MTS) Validation in the new TkAl all-in-one tool #43708

Implementation of the Muon Track Splitting (MTS) Validation in the new TkAl all-in-one tool #43708

Conversation

mmusich commented Jan 12, 2024 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Jan 12, 2024 • edited Loading

cmsbuild commented Jan 12, 2024

cmsbuild commented Jan 12, 2024

cmsbuild commented Jan 12, 2024

mmusich commented Jan 12, 2024

cmsbuild commented Jan 13, 2024

Unit Tests

Comparison Summary

cmsbuild commented Jan 14, 2024

cmsbuild commented Jan 14, 2024

mmusich commented Jan 14, 2024

cmsbuild commented Jan 14, 2024

Comparison Summary

perrotta commented Jan 15, 2024

cmsbuild commented Jan 15, 2024

rappoccio commented Jan 15, 2024

mmusich commented Jan 12, 2024 •

edited

Loading

cmsbuild commented Jan 12, 2024 •

edited

Loading