Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTPPS create Reconstruction workflow test #43641

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

Glitchmin
Copy link
Contributor

@Glitchmin Glitchmin commented Dec 28, 2023

PR description:

This PR adds a new test RecoPPS/Local/TestCTPPSReconstruction that runs RecoPPS/Local/test/2023_lhcinfo_test_recoCTPPS_cfg.py, checking if the standard reconstruction workflow is not crashing.
This workflow:

  • transforms data using RawToDigi
  • reconstructs collisions using recoCTPPS
  • creates proton reconstruction plots using CTPPSProtonReconstructionPlotter

and uses auto:run3_data Global Tag

PR validation:

Run scram b runtests to see the mentioned test in the test sequence

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 28, 2023

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43641/38299

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Glitchmin (Adam Kulczycki) for master.

It involves the following packages:

  • RecoPPS/Local (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@forthommel, @grzanka, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43641/38300

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #43641 was updated. @mandrenguyen, @cmsbuild, @jfernan2 can you please check and sign again.

@perrotta
Copy link
Contributor

perrotta commented Jan 2, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-276bc9/36695/summary.html
COMMIT: 5151d68
CMSSW: CMSSW_14_0_X_2024-01-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43641/36695/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@Glitchmin
Copy link
Contributor Author

@jfernan2 @mandrenguyen @antoniovilela @sextonkennedy @rappoccio can you please have a look at this, comment and/or sign? It would mean a lot for me to have it merged this week (of course it's not a problem if it won't happen).

@mandrenguyen
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

@cms-sw/orp-l2 this is a simple PR, likely not affecting other workflows or tests: could you please merge at your earliest opportunity, as Adam and the PPS team would like to profit of having it in the release?

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d2d7ad6 into cms-sw:master Jan 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants