-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTPPS create Reconstruction workflow test #43641
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43641/38299
|
A new Pull Request was created by @Glitchmin (Adam Kulczycki) for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
9e73e07
to
5151d68
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43641/38300
|
Pull request #43641 was updated. @mandrenguyen, @cmsbuild, @jfernan2 can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-276bc9/36695/summary.html Comparison SummarySummary:
|
@jfernan2 @mandrenguyen @antoniovilela @sextonkennedy @rappoccio can you please have a look at this, comment and/or sign? It would mean a lot for me to have it merged this week (of course it's not a problem if it won't happen). |
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/orp-l2 this is a simple PR, likely not affecting other workflows or tests: could you please merge at your earliest opportunity, as Adam and the PPS team would like to profit of having it in the release? |
+1 |
PR description:
This PR adds a new test
RecoPPS/Local/TestCTPPSReconstruction
that runsRecoPPS/Local/test/2023_lhcinfo_test_recoCTPPS_cfg.py
, checking if the standard reconstruction workflow is not crashing.This workflow:
RawToDigi
recoCTPPS
CTPPSProtonReconstructionPlotter
and uses
auto:run3_data
Global TagPR validation:
Run
scram b runtests
to see the mentioned test in the test sequence