Made modules global in RecoEcal/EgammaClusterProducers

[Dr15Jones]

PR description:

• removed use of beginRun methods and the mutable state
• no more mutable state allowed change to global

This is part of the work where framework requires stream modules to explicitly state they want Run/LuminosityBlock transitions.

PR validation:

Code compiles.

[cmsbuild]

cms-bot internal usage

[Dr15Jones]

@makortel FYI

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43651/38310

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• RecoEcal/EgammaClusterProducers (reconstruction)

@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@varuns23, @sobhatta, @lgray, @a-kapoor, @jainshilpi, @afiqaize, @Prasant1993, @rovere, @argiro, @thomreis, @Sam-Harper, @rchatter, @valsdav, @missirol, @ram1123, @wang0jin, @sameasy, @ReyerBand this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1dc386/36703/summary.html
COMMIT: 47a0459
CMSSW: CMSSW_14_0_X_2024-01-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43651/36703/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 27 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 1225
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3246030
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1