Including short tracks resolution method in DQM #43613

borzari · 2023-12-20T01:56:01Z

PR description:

This PR implements a data-driven method to artificially shorten muon tracks to assess the tracking pT resolution of short tracks.

It relies on shortening the muon tracks by creating track candidates with new hit collections that have the outermost hits removed from the original collection. The new track candidates are refitted to calculate the pT resolution, defined as pT short track / pT of long track. Currently, tracks are being shortened to have 3 to 8 layers, with no missing middle layers. The pT resolution histograms have been included in the tracking DQM sequence, and will also be included in the DQM GUI offline tracking layout.

The latest presentation about this work can be found here, and contains links to older presentations as well.

PR validation:

The shortening procedure was verified in CMSSW 13_1_0_pre2 with MC events using RelValZMM_14 dataset with and without PU, and with events from collected data using Run 3 Muon_2022G dataset. It works as intended and provides the pT resolution histograms following the expectations.

The complete set of changes comprising the inclusion of the tracks shortening module in the DQM sequence and the creation of the histograms inside the DQM root file was checked in CMSSW 14_0_0_pre0 with runTheMatrix workflows 11650.0 (Run 3 ZMM) to check that the shortening procedure worked as expected and that the histograms were added to the DQM root file, and 11634.0 (Run 3 ttbar) to ensure that the DQM step throughput wouldn't be affected in processes having few muon tracks. Both checks were successful.

cmsbuild · 2023-12-20T01:56:26Z

cms-bot internal usage

cmsbuild · 2023-12-20T02:02:53Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43613/38263

This PR adds an extra 64KB to repository
Found files with invalid states:
- RecoTracker/FinalTrackSelectors/test/Alignment_Tracker_DataMCValidation_Harvest_cfg.py:
  - Added: 34c6853
  - Deleted: 2cc048e
- RecoTracker/FinalTrackSelectors/python/SingleLongTrackProducer_cfi.py:
  - Added: 34c6853, edab588
  - Deleted: 40ce280
- RecoTracker/FinalTrackSelectors/python/SingleLongTrackSeq_cff.py:
  - Added: 34c6853
  - Deleted: 40ce280
- RecoTracker/FinalTrackSelectors/test/filesData.txt:
  - Added: 34c6853
  - Deleted: 2cc048e
- RecoTracker/FinalTrackSelectors/plugins/LongTrackFilter.cc:
  - Added: 34c6853
  - Deleted: 40ce280
- RecoTracker/FinalTrackSelectors/test/AOD_Alignment_Tracker_DataMCValidation_cfg.py:
  - Added: 34c6853
  - Modified: 054e681, d69791f
  - Deleted: 2cc048e
- DQM/TrackingMonitorSource/interface/ShortenedTrackResolution.h:
  - Added: 054e681
  - Modified: d69791f, 40ce280
  - Deleted: edab588
- RecoTracker/FinalTrackSelectors/test/runAllAlignment.py:
  - Added: 34c6853
  - Modified: 054e681
  - Deleted: 2cc048e
- RecoTracker/FinalTrackSelectors/test/filesDataAOD.txt:
  - Added: 34c6853
  - Deleted: 2cc048e
- RecoTracker/FinalTrackSelectors/python/singleLongTrackProducer_cfi.py:
  - Added: 40ce280
  - Deleted: edab588

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43613/38263/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43613/38263/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43613/38263/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43613/38263/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2023-12-20T03:02:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43613/38264

This PR adds an extra 68KB to repository
Found files with invalid states:
- RecoTracker/FinalTrackSelectors/test/Alignment_Tracker_DataMCValidation_Harvest_cfg.py:
  - Added: 34c6853
  - Deleted: 2cc048e
- RecoTracker/FinalTrackSelectors/python/SingleLongTrackProducer_cfi.py:
  - Added: 34c6853, edab588
  - Deleted: 40ce280
- RecoTracker/FinalTrackSelectors/python/SingleLongTrackSeq_cff.py:
  - Added: 34c6853
  - Deleted: 40ce280
- RecoTracker/FinalTrackSelectors/test/filesData.txt:
  - Added: 34c6853
  - Deleted: 2cc048e
- RecoTracker/FinalTrackSelectors/plugins/LongTrackFilter.cc:
  - Added: 34c6853
  - Deleted: 40ce280
- RecoTracker/FinalTrackSelectors/test/AOD_Alignment_Tracker_DataMCValidation_cfg.py:
  - Added: 34c6853
  - Modified: 054e681, d69791f
  - Deleted: 2cc048e
- DQM/TrackingMonitorSource/interface/ShortenedTrackResolution.h:
  - Added: 054e681
  - Modified: d69791f, 40ce280
  - Deleted: edab588
- RecoTracker/FinalTrackSelectors/test/runAllAlignment.py:
  - Added: 34c6853
  - Modified: 054e681
  - Deleted: 2cc048e
- RecoTracker/FinalTrackSelectors/test/filesDataAOD.txt:
  - Added: 34c6853
  - Deleted: 2cc048e
- RecoTracker/FinalTrackSelectors/python/singleLongTrackProducer_cfi.py:
  - Added: 40ce280
  - Deleted: edab588

cmsbuild · 2023-12-20T03:03:16Z

A new Pull Request was created by @borzari for master.

It involves the following packages:

DQM/TrackingMonitorSource (dqm)
RecoTracker/FinalTrackSelectors (reconstruction)

@syuvivida, @tjavaid, @cmsbuild, @nothingface0, @antoniovagnerini, @jfernan2, @mandrenguyen, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @rovere, @felicepantaleo, @sroychow, @fioriNTU, @idebruyn, @dgulhan, @jandrea, @mtosi, @mmusich, @gpetruc, @GiacomoSguazzoni, @JanFSchulte, @threus, @VinInn, @missirol, @VourMa this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

slava77 · 2023-12-20T03:28:55Z

@cmsbuild please test

cmsbuild · 2023-12-20T08:23:51Z

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c6f42/36594/summary.html
COMMIT: 37baa71
CMSSW: CMSSW_14_0_X_2023-12-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43613/36594/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

RecoTracker/FinalTrackSelectors/plugins/SingleLongTrackProducer.cc

cmsbuild · 2024-01-08T16:16:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43613/38354

This PR adds an extra 40KB to repository

cmsbuild · 2024-01-08T16:16:31Z

Pull request #43613 was updated. @mandrenguyen, @tjavaid, @cmsbuild, @rvenditti, @jfernan2, @syuvivida, @nothingface0, @antoniovagnerini can you please check and sign again.

mmusich · 2024-01-08T16:16:52Z

@cmsbuild, please test

cmsbuild · 2024-01-08T19:00:45Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c6f42/36741/summary.html
COMMIT: f61b144
CMSSW: CMSSW_14_0_X_2024-01-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43613/36741/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3247277
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3247252
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 34.181999999999974 KiB( 47 files compared)
DQMHistoSizes: changed ( 1000.0,... ): 1.266 KiB Tracking/ShortTrackResolution
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

jfernan2 · 2024-01-09T09:00:30Z

+1

mmusich · 2024-01-10T12:09:17Z

@cms-sw/dqm-l2 ping.

tjavaid · 2024-01-12T10:51:25Z

+1

cmsbuild · 2024-01-12T10:51:53Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2024-01-12T14:58:57Z

+1

cmsbuild added this to the CMSSW_14_0_X milestone Dec 20, 2023

cmsbuild added reconstruction-pending dqm-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels Dec 20, 2023

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Dec 20, 2023

borzari mentioned this pull request Dec 20, 2023

Adding short tracks resolution in DQM GUI offline layout dmwm/deployment#1297

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 20, 2023

cmsbuild added tests-started and removed tests-pending labels Dec 20, 2023

cmsbuild added tests-rejected and removed tests-started labels Dec 20, 2023

jfernan2 reviewed Dec 20, 2023

View reviewed changes

RecoTracker/FinalTrackSelectors/plugins/SingleLongTrackProducer.cc Show resolved Hide resolved

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Dec 21, 2023

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Jan 8, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 8, 2024

cmsbuild added tests-started and removed tests-pending labels Jan 8, 2024

cmsbuild added tests-approved and removed tests-started labels Jan 8, 2024

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jan 9, 2024

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jan 12, 2024

cmsbuild added orp-approved and removed orp-pending labels Jan 12, 2024

cmsbuild merged commit 4b81ab1 into cms-sw:master Jan 12, 2024
12 checks passed

cmsbuild mentioned this pull request Jan 13, 2024

Implementation of the Muon Track Splitting (MTS) Validation in the new TkAl all-in-one tool #43708

Merged

mmusich mentioned this pull request Jan 17, 2024

Adapt shortened tracks resolution method to work with AlCaReco event content #43729

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Including short tracks resolution method in DQM #43613

Including short tracks resolution method in DQM #43613

borzari commented Dec 20, 2023

cmsbuild commented Dec 20, 2023 •

edited

Loading

cmsbuild commented Dec 20, 2023

cmsbuild commented Dec 20, 2023

cmsbuild commented Dec 20, 2023

slava77 commented Dec 20, 2023

cmsbuild commented Dec 20, 2023

cmsbuild commented Jan 8, 2024

cmsbuild commented Jan 8, 2024

mmusich commented Jan 8, 2024

cmsbuild commented Jan 8, 2024

jfernan2 commented Jan 9, 2024

mmusich commented Jan 10, 2024

tjavaid commented Jan 12, 2024

cmsbuild commented Jan 12, 2024

rappoccio commented Jan 12, 2024

Including short tracks resolution method in DQM #43613

Including short tracks resolution method in DQM #43613

Conversation

borzari commented Dec 20, 2023

PR description:

PR validation:

cmsbuild commented Dec 20, 2023 • edited Loading

cmsbuild commented Dec 20, 2023

cmsbuild commented Dec 20, 2023

cmsbuild commented Dec 20, 2023

slava77 commented Dec 20, 2023

cmsbuild commented Dec 20, 2023

Clang Build

cmsbuild commented Jan 8, 2024

cmsbuild commented Jan 8, 2024

mmusich commented Jan 8, 2024

cmsbuild commented Jan 8, 2024

Comparison Summary

jfernan2 commented Jan 9, 2024

mmusich commented Jan 10, 2024

tjavaid commented Jan 12, 2024

cmsbuild commented Jan 12, 2024

rappoccio commented Jan 12, 2024

cmsbuild commented Dec 20, 2023 •

edited

Loading