-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TkAlStyle
includes and add unit tests
#43650
Conversation
type bug-fix |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43650/38309
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@cmsbuild, @consuegs, @saumyaphor4252, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c56b1/36702/summary.html Comparison SummarySummary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stilish comments are, of course, unimportant: just apply them if you wish.
Please just check my doubts related to L237 and L2329 of trackSplitPlot.C: if you confirm that it is OK I'll sign for AlCa
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
since we're not in a hurry with this, I'll implement the comments on the style of the commented lines as well. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43650/38312
|
Pull request #43650 was updated. @perrotta, @cmsbuild, @saumyaphor4252, @consuegs can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c56b1/36705/summary.html Comparison SummarySummary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
there are further developments on top of this PR that are awaiting this to be merged. |
+1 |
PR description:
PR #38304 moved
TkAlStyle.cc
fromAlignment/OfflineValidation/macros
to a header / source implementation in order to include the header file in other developments.This has broken few macros in
cmssw
that contain the incorrect include: this PR fixes the issue, while adding back some lost functionalities originally included in PR #15570 and removed in the meanwhile.The file
Alignment/OfflineValidation/macros/trackSplitPlot.C
has apparently not been touched since the centralcode-format
campaign, and thus in order for this PR to pass the standard code quality requirements, it is now heavily changed (albeit basically all of it is just formatting).I profit of this PR to add a dedicated unit test profiting of the existing file
Alignment/OfflineValidation/test/testTkAlStyle.C
.PR validation:
Relies on the compilation and the newly added unit test (
scram b runtests_testTkAlStyle
runs fine).If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, might be backported to 13.0.X to be used for the 2022+2023 re-reco alignment campaigns.