Refactoring PI plugin for PPSTiming -- added input parameters

[Kszemka]

PR description:

PR contains changes that allows user to provide input parameters when using Payload Inspector - PPSTimingCalibration module on the cms-conddb website.

PR validation:

Testing stays the same at it was in the previous version for PPSTimingCalibration - Payload Inspector, test is defined in testPPSTimingCalibration.sh.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43543/38122

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @Kszemka (Aleksandra Krzemińska) for master.

It involves the following packages:

• CondCore/CTPPSPlugins (db)

@consuegs, @saumyaphor4252, @cmsbuild, @perrotta, @francescobrivio can you please review it and eventually sign? Thanks.
@PonIlya, @mmusich, @yuanchao, @fabferro, @rsreds this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[grzanka]

@perrotta would it be possible to run a battery of tests via cmsbot here ?

[perrotta]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5c586/36696/summary.html
COMMIT: 90b4bae
CMSSW: CMSSW_14_0_X_2024-01-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43543/36696/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testPPSTimingCalibration had ERRORS

Comparison Summary

Summary:

• You potentially removed 12 lines from the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247252
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

@Kszemka the unit test failure is due to the modifications implemented in this PR: please check and fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43543/38342

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #43543 was updated. @perrotta, @cmsbuild, @consuegs, @saumyaphor4252, @francescobrivio can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5c586/36729/summary.html
COMMIT: 9329689
CMSSW: CMSSW_14_0_X_2024-01-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43543/36729/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 90 lines to the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247252
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1