-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Phase-2 geometry (Up to D85) #38702
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38702/30997
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages:
@perrotta, @rappoccio, @Dr15Jones, @jordan-martins, @bsunanda, @makortel, @bbilin, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @civanch, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a749/26162/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
hold |
Pull request has been put on hold by @srimanob |
@cms-sw/pdmv-l2 any objection to merge this? |
+pdmv |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
Hi @iarspider |
fix failing unit tests after #38702 merge (Drop of geometry D49)
Staring from CMSSW_12_6_X_2022-10-05-1100, unit tests seem to be OK now. |
PR description:
This PR is to clean up Phase-2 Geometry as discussed in
#38594
There will be a follow up PR on resetting workflow number.
PR validation:
Comparison of outputs from
runTheMatrix.py --what upgrade -n
shows that we have less Phase-2 workflows. All D49-D85 workflows are removed. Log files can be found in/afs/cern.ch/user/s/srimanob/public/ForPhase2SW/Geometry/2022CleanUp
If this PR is a backport please specify the original PR and why you need to backport that PR.
No need of backport, or special requests.