Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Validation/Geometry to D92 #39590

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Oct 4, 2022

PR description:

This PR provided fix of unit test after #38702 was merged. Discussion is in #38594 (comment)

PR validation:

None. To be tested with #39571 and #39572

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport and no need of backport.

@srimanob
Copy link
Contributor Author

srimanob commented Oct 4, 2022

Full test is done in #39571 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39590/32389

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2022

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Validation/Geometry (geometry, dqm)

@civanch, @Dr15Jones, @makortel, @emanueleusai, @ianna, @ahmad3213, @cmsbuild, @bsunanda, @jfernan2, @mdhildreth, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@youyingli, @vargasa, @rovere, @fabiocos, @apsallid, @lecriste, @missirol, @rishabhCMS, @ebrondol, @rbartek this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Oct 4, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc3c29/27976/summary.html
COMMIT: 969b56e
CMSSW: CMSSW_12_6_X_2022-10-03-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39590/27976/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dc3c29/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3432650
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3432619
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Oct 5, 2022

@cms-sw/geometry-l2 @cms-sw/dqm-l2 with this (simple) fix the unit test materialBudgetHGCalPlot now succeed, instead of failing as in the IBs. Would you agree signing, so that this fix can be included already in pre3?

@civanch
Copy link
Contributor

civanch commented Oct 5, 2022

+1

fixes are obvious

@perrotta
Copy link
Contributor

perrotta commented Oct 5, 2022

+1

  • I agree with @civanch that these fixes are obvious: let me superseed the @cms-sw/dqm-l2 signature here, then, so that we can try to recover a few red buttons in the IB test pages

@perrotta
Copy link
Contributor

perrotta commented Oct 5, 2022

merge

@cmsbuild cmsbuild merged commit 2b1850d into cms-sw:master Oct 5, 2022
@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants