Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Run3 wfs (NanoV10) #38733

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Add Run3 wfs (NanoV10) #38733

merged 3 commits into from
Jul 20, 2022

Conversation

kskovpen
Copy link
Contributor

PR description:

Addition of the new Run3 NanoV10 wfs for data (140.001, 140.002) and MC (offset .602). Also addresses https://its.cern.ch/jira/projects/PDMVRELVALS/issues/PDMVRELVALS-155 (for data). Comments are welcome.

@bbilin @jmartinb @rappoccio @kmaeshima @cms-sw/xpog-l2 @mmusich

PR validation:

Tested on the aforementioned wfs.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38733/31037

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kskovpen for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@kskovpen
Copy link
Contributor Author

test parameters:

@kskovpen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd7be7/26228/summary.html
COMMIT: 9e8924e
CMSSW: CMSSW_12_5_X_2022-07-13-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38733/26228/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd7be7/26228/git-merge-result

@srimanob
Copy link
Contributor

Don't you need also to test new wf of 140.001, 140.002?

@kskovpen
Copy link
Contributor Author

kskovpen commented Jul 14, 2022

Don't you need also to test new wf of 140.001, 140.002?

I do, but first I wanted to test the ones in upgrade setup. If all can be run at once with bot, please let me know.

@kskovpen
Copy link
Contributor Author

test parameters:

  • workflow = 11634.602,140.001,140.002

@kskovpen
Copy link
Contributor Author

please test

@srimanob
Copy link
Contributor

You need to use

relvals_opt= -w standard,highstats,pileup,generator,extendedgen,production,cleanedupgrade,ged

@srimanob
Copy link
Contributor

@cmsbuild please abort

@cmsbuild
Copy link
Contributor

Pull request #38733 was updated. @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again.

@kskovpen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd7be7/26314/summary.html
COMMIT: cc0f57c
CMSSW: CMSSW_12_5_X_2022-07-18-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38733/26314/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cd7be7/11634.602_TTbar_14TeV+2021_NanoV10+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cd7be7/140.001_RunMinimumBias2022+RunMinimumBias2022+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cd7be7/140.002_RunZeroBias2022+RunZeroBias2022+HLTRUN3+RECONANORUN3+HARVESTRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3662417
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3662381
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

@kskovpen
Copy link
Contributor Author

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2bf72f8 into cms-sw:master Jul 20, 2022
@mariadalfonso
Copy link
Contributor

@kskovpen
we need a backport for 12_4 as when we start the production of the nanoV10 we want to check that we have this wf unmodified

@kskovpen
Copy link
Contributor Author

@mariadalfonso , 140.001 and 140.002 wfs were a bit adjusted in #38830. Once the PR is merged, we will make a back port to 12_4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants