Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trivial V10 customize (12_4) #38667

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Conversation

mariadalfonso
Copy link
Contributor

Next central production for Run3 should be procured with the following options with the cmsdriver command

cmsDriver.py step5 -s NANO --era Run3 --customise=PhysicsTools/NanoAOD/V10/nano_cff.nanoAOD_customizeV10

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2022

A new Pull Request was created by @mariadalfonso for CMSSW_12_4_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso mariadalfonso changed the title trivial V10 customize trivial V10 customize (12_4) Jul 9, 2022
@qliphy
Copy link
Contributor

qliphy commented Jul 10, 2022

backport of #38668

@mariadalfonso
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-561602/26109/summary.html
COMMIT: 6ff5879
CMSSW: CMSSW_12_4_X_2022-07-10-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38667/26109/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676076
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3676046
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mariadalfonso
Copy link
Contributor Author

+xpog

initial customisation for V10nano

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 12, 2022

+1

@cmsbuild cmsbuild merged commit ffffcce into cms-sw:CMSSW_12_4_X Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants