Reorganize FastSim Run3 workflow #38660

srimanob · 2022-07-08T18:38:14Z

PR description:

This PR is to reorganize the Run3 FastSim workflow.

Before:

11634.0 (FullSim) ==> 11634.301 (FastSim) seems to be easy, but it needs several hacks if we would like to make it works for PU, Premixing test
With this PR, FastSim has its own key in upgrade. So it needs less hacks to handles several PU workflows.

To be done:

Make the Premixing workflow for FastSim.

Comments are welcomed.

PR validation:

Running with configs out from the following runTheMatrix:
runTheMatrix.py --what upgrade -l 13234.0,13434.0,13240.303 --wm init

Comparison of workflow list can be done with
diff /afs/cern.ch/user/s/srimanob/public/ForFastSim/runTheMatrix_original.log /afs/cern.ch/user/s/srimanob/public/ForFastSim/runTheMatrix_withPR_v2.log
It shows that previous .301, .302, .303 are removed, and new workflows are added, started from 13200..

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No need of backport.

cmsbuild · 2022-07-08T18:44:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38660/30947

This PR adds an extra 72KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/README.md modified in PR(s): Add run3 tracking low pu era #33532
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532

cmsbuild · 2022-07-08T18:45:13Z

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

srimanob · 2022-07-08T18:45:53Z

test parameters:

workflows = 13234.0,13434.0,13240.303

srimanob · 2022-07-08T18:47:49Z

@cmsbuild please test

kpedro88 · 2022-07-08T20:33:01Z

@srimanob have you diffed the output of runTheMatrix.py -w upgrade -n before and after this modification to ensure that only the intended workflows were added and no other changes occurred? (It's unfortunate to have to make so many manual modifications, but the need to use different pileup inputs seems to make this the easiest path.)

srimanob · 2022-07-08T21:56:06Z

Hi @kpedro88
Difference can seen with
diff /afs/cern.ch/user/s/srimanob/public/ForFastSim/runTheMatrix_original.log /afs/cern.ch/user/s/srimanob/public/ForFastSim/runTheMatrix_withPR.log

It shows that previous .301, .302, .303 are removed, and new workflows are added, started from 13200. This PR adds more workflows than needed, i.e. it includes .5XX (Patatrack) into fastsim. Cleaning can be done.

srimanob · 2022-07-08T22:02:48Z

FYI @sbein

cmsbuild · 2022-07-08T22:37:51Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53c47c/26090/summary.html
COMMIT: f837678
CMSSW: CMSSW_12_5_X_2022-07-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38660/26090/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-53c47c/13234.0_TTbar_14TeV+2021FS+TTbar_14TeV_TuneCP5_FastSimRun3+HARVESTFastRun3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-53c47c/13240.303_MinBias_14TeV+2021FS_Run3FSMBMixing+MinBias_14TeV_pythia8_TuneCP5_FastSimRun3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-53c47c/13434.0_TTbar_14TeV+2021FSPU+TTbar_14TeV_TuneCP5_FastSimRun3PU+HARVESTFastRun3PU

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3611876
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3611840
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 206 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-07-09T07:23:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38660/30951

This PR adds an extra 72KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/README.md modified in PR(s): Add run3 tracking low pu era #33532
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532

sbein · 2022-07-14T10:05:15Z

+1

srimanob · 2022-07-17T17:05:35Z

+Upgrade

Presented in the SIM meeting, https://indico.cern.ch/event/1182398/
I prefer this PR to go first, to make sure that overall is OK, including IB test. Then I will need to rebase #38736 and also update the Nano validation.

srimanob · 2022-07-18T16:49:26Z

@cms-sw/pdmv-l2
Could you please review this PR? I will then rebase another PR on the miniaod + nanoaod validations for FastSim. Thanks.
The summary is of all, including this PR is at https://indico.cern.ch/event/1182398/contributions/4967724/attachments/2480443/4258755/20220715-Workflows.pdf

kskovpen · 2022-07-18T17:56:54Z

Thanks a lot for all the updates @srimanob . I wonder if jenkins tests would catch all the existing wfs that could be potentially touched by these changes (I haven't seen any problems). Otherwise, it is fine with us.

srimanob · 2022-07-18T20:11:59Z

Hi @kskovpen

Yes, this PR covers FastSim NoPU, FastSim PU, and MinBias PU creation (13234.0,13434.0,13240.303). And they will be part of IB test.

The PR test after merging this PR will cover FastSim NoPU and FastSim PU.

kskovpen · 2022-07-18T20:23:15Z

+pdmv

cmsbuild · 2022-07-18T20:23:37Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

srimanob · 2022-07-19T08:57:22Z

@perrotta @qliphy
Not sure if you have comment on this PR before merging. I can't join the release meeting today. I can follow up later.

The plan is to merge this PR first. Let's IB done, and see nothing wrong. Then I will rebase #38736 to support MiniAOD and NanoAOD DQM, and some structure change for FastSim.

srimanob · 2022-07-19T11:27:56Z

Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

+        'GT' : 'auto:phase1_2022_realistic',
+        'HLTmenu': '@relval2022',
+        'Era' : 'Run3_FastSim',
+        'BeamSpot': 'Run3RoundOptics25ns13TeVLowSigmaZ',


Following the coming #38760,
should I update BS used in this PR or I put the update in the coming PR (together with MIniAOD/NanoAOD)? @perrotta @qliphy

I am fine with both options. maybe @perrotta has preference?

Hi @qliphy
As those PR is still in progress. I prefer to merge this first. The next PR will come in 2-3 days. Thanks.

srimanob · 2022-07-19T19:50:58Z

Anything that stops to merge this PR?

perrotta · 2022-07-20T13:32:27Z

+1

Let update all beam spot coherently in Update BeamSpot in Run3 MC GTs + swap Run3RoundOptics25ns13TeVLowSigmaZ with Realistic25ns13p6TeVEarly2022Collision vtx smearing #38760

Norraphat added 2 commits July 8, 2022 19:50

Reorganize fastsim workflows

444cc63

Fix harvesting and clean up

91fc0b8

cmsbuild added this to the CMSSW_12_5_X milestone Jul 8, 2022

cmsbuild added code-checks-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Jul 8, 2022

clean up

f837678

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 8, 2022

cmsbuild added tests-started and removed tests-pending labels Jul 8, 2022

cmsbuild added tests-approved and removed tests-started labels Jul 8, 2022

more clean up

070efa9

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Jul 9, 2022

cmsbuild added tests-approved and removed tests-started labels Jul 13, 2022

cmsbuild mentioned this pull request Jul 14, 2022

Add Run3 wfs (NanoV10) #38733

Merged

This was referenced Jul 14, 2022

Add miniAODDQM FastSim Validation #38736

Closed

Don't recluster jets in HI miniAOD for Run 3 #38711

Merged

Update BeamSpot in Run3 MC GTs + swap Run3RoundOptics25ns13TeVLowSigmaZ with Realistic25ns13p6TeVEarly2022Collision vtx smearing #38760

Merged

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 17, 2022

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Jul 18, 2022

srimanob commented Jul 19, 2022

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Jul 20, 2022

cmsbuild merged commit eb9bfe1 into cms-sw:master Jul 20, 2022

cmsbuild mentioned this pull request Jul 20, 2022

[DQM] Fix for bug in DT DQM at Online #38802

Merged

slava77 mentioned this pull request Jul 21, 2022

reco comparisons: 2021 FastSim workflows 13234, 13434 cms-sw/cms-bot#1794

Merged

kpedro88 mentioned this pull request Nov 25, 2022

Addition of WFs for postEE scenario [12_4_X] #40138

Merged

srimanob mentioned this pull request Dec 7, 2022

[Backport] Run-3 FastSim Mini and Nano workflow for validation #40256

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reorganize FastSim Run3 workflow #38660

Reorganize FastSim Run3 workflow #38660

srimanob commented Jul 8, 2022 •

edited

Loading

cmsbuild commented Jul 8, 2022

cmsbuild commented Jul 8, 2022

srimanob commented Jul 8, 2022

srimanob commented Jul 8, 2022

kpedro88 commented Jul 8, 2022

srimanob commented Jul 8, 2022 •

edited

Loading

srimanob commented Jul 8, 2022

cmsbuild commented Jul 8, 2022

cmsbuild commented Jul 9, 2022

sbein commented Jul 14, 2022

srimanob commented Jul 17, 2022

srimanob commented Jul 18, 2022

kskovpen commented Jul 18, 2022

srimanob commented Jul 18, 2022

kskovpen commented Jul 18, 2022

cmsbuild commented Jul 18, 2022

srimanob commented Jul 19, 2022

srimanob Jul 19, 2022

qliphy Jul 20, 2022

srimanob Jul 20, 2022

srimanob commented Jul 19, 2022 •

edited

Loading

perrotta commented Jul 20, 2022

Reorganize FastSim Run3 workflow #38660

Reorganize FastSim Run3 workflow #38660

Conversation

srimanob commented Jul 8, 2022 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Jul 8, 2022

cmsbuild commented Jul 8, 2022

srimanob commented Jul 8, 2022

srimanob commented Jul 8, 2022

kpedro88 commented Jul 8, 2022

srimanob commented Jul 8, 2022 • edited Loading

srimanob commented Jul 8, 2022

cmsbuild commented Jul 8, 2022

Comparison Summary

cmsbuild commented Jul 9, 2022

sbein commented Jul 14, 2022

srimanob commented Jul 17, 2022

srimanob commented Jul 18, 2022

kskovpen commented Jul 18, 2022

srimanob commented Jul 18, 2022

kskovpen commented Jul 18, 2022

cmsbuild commented Jul 18, 2022

srimanob commented Jul 19, 2022

srimanob Jul 19, 2022

Choose a reason for hiding this comment

qliphy Jul 20, 2022

Choose a reason for hiding this comment

srimanob Jul 20, 2022

Choose a reason for hiding this comment

srimanob commented Jul 19, 2022 • edited Loading

perrotta commented Jul 20, 2022

srimanob commented Jul 8, 2022 •

edited

Loading

srimanob commented Jul 8, 2022 •

edited

Loading

srimanob commented Jul 19, 2022 •

edited

Loading