Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Run-3 FastSim Mini and Nano workflow for validation #40256

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Dec 7, 2022

PR description:

Update Run-3 FastSim workflow, to include Mini and Nano validations.
This PR is a backport of #38660 and #38834

PR validation:

Test with workflow 13234.0,13434.0,13240.303

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38660 and #38834

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2022

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • DQMOffline/Configuration (dqm)
  • DQMOffline/Muon (dqm)
  • Validation/RecoTau (dqm)

@perrotta, @rappoccio, @kskovpen, @bbilin, @emanueleusai, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @pmandrik, @syuvivida, @sunilUIET, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @abbiendi, @kpedro88, @Martin-Grunewald, @trtomei, @threus, @cericeci, @makortel, @JanFSchulte, @jhgoh, @dgulhan, @missirol, @HuguesBrun, @slomeo, @ptcox, @trocino, @beaucero, @rociovilar, @barvic, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @mmusich, @mtosi, @fabiocos, @Fedespring, @calderona, @lecriste, @sameasy this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Dec 7, 2022

@cmsbuild please test

@srimanob srimanob changed the title backport [Backport] Run-3 FastSim Mini and Nano workflow for validation Dec 7, 2022
@srimanob
Copy link
Contributor Author

srimanob commented Dec 7, 2022

FYI @cms-sw/xpog-l2

@srimanob
Copy link
Contributor Author

srimanob commented Dec 7, 2022

FYI @cms-sw/fastsim-l2

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2022

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-274474/29502/summary.html
COMMIT: b10b7ec
CMSSW: CMSSW_12_4_X_2022-12-06-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40256/29502/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 11634.301

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2022

@srimanob
Copy link
Contributor Author

srimanob commented Dec 7, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-274474/29503/summary.html
COMMIT: 70d7485
CMSSW: CMSSW_12_4_X_2022-12-06-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40256/29503/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3665247
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3665217
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 206 log files, 159 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 3 / 48 workflows

@perrotta
Copy link
Contributor

backport of #38834

@cmsbuild
Copy link
Contributor

Pull request #40256 was updated. @perrotta, @rappoccio, @kskovpen, @bbilin, @emanueleusai, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @pmandrik, @syuvivida, @sunilUIET, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please check and sign again.

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-274474/29895/summary.html
COMMIT: 5f5995c
CMSSW: CMSSW_12_4_X_2023-01-08-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40256/29895/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3665247
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3665223
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 159 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 3 / 48 workflows

@srimanob
Copy link
Contributor Author

Hi @cms-sw/dqm-l2 @cms-sw/pdmv-l2
Could you please check and re-sign again? The last fix includes comments from @perrotta
Thx.

@srimanob
Copy link
Contributor Author

+Upgrade

Two Run3 FastSim workflows (13234.0, 13434.0) run fine with Validation, DQM and harvesting. More cleanup to exclude FastSim workflows from upgrade will be done in master. No real need to clean up 12_4 (but can be done after master).

@sunilUIET
Copy link
Contributor

+pdmv

@rappoccio
Copy link
Contributor

@cms-sw/dqm-l2 just waiting on your signature for this, after it is merged and runs through an IB we will cut a new 12_4 as requested.

@srimanob
Copy link
Contributor Author

Could you please consider to merge, @perrotta @rappoccio ? So that we can have an IB before making a release.
The last commit does not have DQM-related part. Thanks.

@perrotta
Copy link
Contributor

Could you please consider to merge, @perrotta @rappoccio ? So that we can have an IB before making a release. The last commit does not have DQM-related part. Thanks.

@srimanob yes we plan to bypass @cms-sw/dqm-l2 signature before this evening 2300 IB, so that tomorrow we can build 12_4_next. Let just wait for a few more hours in case they want to have a look...

@perrotta
Copy link
Contributor

perrotta commented Jan 12, 2023

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 2c51183 into cms-sw:CMSSW_12_4_X Jan 12, 2023
@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants