-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-gex134 Modify C17 to see the new numbering of HCAL #37951
Conversation
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37951/30018
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46e449/24726/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1 |
Do we expect to see any changes in Phase-2 D88 in both DDD and DD4hep from this PR? Just to make sure to understand the effect of this PR. Thanks. |
This make changes to some rare process. I am not sure if the difference can be seen in tests with small samples |
+Upgrade This fix follows the validation report of HCAL [*] and it should be the target for the next Phase-2 DD4hep validation. However, it seems unclear to me if the change is expected also for DDD as file |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@srimanob will you take care of notifying it to @cms-sw/pdmv-l2 , so that it can be correctly taken into account in that validation campaign? |
@srimanob Please uphold this PR. It makes changes in the right direction |
unhold |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@cmsbuild please test workflow 39434.911 |
Hi @bsunanda It will be great if you could help to understand more the situation.
Thanks. |
Hi, this is a bug fix and should be included in all Phase 2 scenarios of CMS. Once this is integrated I can update all calorimeter descriptions with this |
type bug-fix |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
Failure in INPUT does not relate to this PR. Would it be better if @bsunanda confirm the issue of bad HCAL ID which still show up in PR test (as mentioned before), |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46e449/27517/summary.html Comparison SummarySummary:
|
+1 |
As this PR merged after 12_6_0_pre2, I would like to remind @cms-sw/pdmv-l2 to make a clear validation statement on the change of D88. REF, see comment |
Thanks @srimanob , we will take a note. |
PR description:
Modify C17 to see the new numbering of HCAL
PR validation:
Use the runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
othing special