Drop tracker geometries T22,T23,T27,T28 - first commit #37874

emiglior · 2022-05-09T20:39:18Z

PR description:

This PR concerns Upgrade.

This PR removes the phase-2 Tracker geometries T22, T23, T27 T28 definitively discarded after the choice of the Inner Tracker layout

ref. https://indico.cern.ch/event/1154888/contributions/4849182/attachments/2434145/4168775/news20220429.pdf slide 3

The PR removes both the geometry files and the corresponding workflows.
Furthermore, as T27 geometry is removed, the GT for geometries with bricked pixels is now 'phase2_realistic_T29'

The file
Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
is also changed in order to preserve the workflow numbers.

Geometries for which large PU200 samples were produced
https://its.cern.ch/jira/browse/PDMVMCPROD-30
are still kept.

No changes are expected in the output for the geometries/workflows which are kept.

PR validation:

The PR was validated with runTheMatrix checking that

w/f numbers for geometries from 2026D76 to 2026D90 did not change
running explicitely the w/f 36600.0 (2026D81) 39400.0 (2026D88) 40200.0 (2026D90)

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport

@adewit @connorpa @mmusich @tsusa @tvami FYI

foo

cmsbuild · 2022-05-09T20:44:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37874/29846

This PR adds an extra 60KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): DeepSC algorithm for ECAL SuperClusters #37115, Add run3 tracking low pu era #33532
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532

cmsbuild · 2022-05-09T20:45:07Z

A new Pull Request was created by @emiglior (Ernesto Migliore) for master.

It involves the following packages:

Configuration/AlCa (alca)
Configuration/Eras (operations)
Configuration/Geometry (geometry, upgrade)
Configuration/PyReleaseValidation (pdmv, upgrade)
Configuration/StandardSequences (operations)
Geometry/CMSCommonData (geometry, upgrade)
Geometry/TrackerCommonData (geometry)

@perrotta, @malbouis, @civanch, @yuanchao, @jordan-martins, @makortel, @cvuosalo, @ianna, @mdhildreth, @tvami, @cmsbuild, @AdrianoDee, @srimanob, @Dr15Jones, @kskovpen, @bbilin, @qliphy, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@felicepantaleo, @kpedro88, @ghugo83, @Martin-Grunewald, @bsunanda, @trtomei, @mmusich, @slomeo, @venturia, @vargasa, @makortel, @JanFSchulte, @dgulhan, @missirol, @beaucero, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @ebrondol, @mtosi, @fabiocos, @lecriste this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami · 2022-05-09T20:50:49Z

@cmsbuild , please test

cmsbuild · 2022-05-10T01:00:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b6106/24553/summary.html
COMMIT: 0017685
CMSSW: CMSSW_12_4_X_2022-05-09-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37874/24553/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3696633
DQMHistoTests: Total failures: 14
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3696597
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 206 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2022-05-10T01:05:27Z

+alca

PR drops Phase-2 tk geometries, the symbolic GT changes accordingly
Jenkins tests pass, differences are known

cvuosalo · 2022-05-10T22:27:13Z

+1

srimanob · 2022-05-11T17:29:32Z

+Upgrade

This PR removes the unused tracker after decision was made on the inner tracker. No change is expected from the PR test as removed workflow has not been used for the short matrix. PR reserves the workflow number as expected.

kskovpen · 2022-05-17T07:38:36Z

+pdmv

perrotta · 2022-05-17T10:11:56Z

Configuration/AlCa/python/autoCondPhase2.py

    'T25' : ( ','.join( [ 'SiPixelSimLorentzAngle_phase2_T25_v0_mc' ,SiPixelSimLARecord,connectionString, "", "2021-03-16 20:00:00.000"] ), ), #uH = 0.053/T (TBPX L2,L3,L4), uH=0.0/T (TBPX L1 TEPX+TFPX)
    'T26' : ( ','.join( [ 'SiPixelSimLorentzAngle_phase2_T25_v0_mc' ,SiPixelSimLARecord,connectionString, "", "2021-03-16 20:00:00.000"] ), ), #uH = 0.053/T (TBPX L2,L3,L4), uH=0.0/T (TBPX L1 TEPX+TFPX)
-    'T27' : ( ','.join( [ 'SiPixelSimLorentzAngle_phase2_T25_v0_mc' ,SiPixelSimLARecord,connectionString, "", "2021-03-16 20:00:00.000"] ), ), #uH = 0.053/T (TBPX L2,L3,L4), uH=0.0/T (TBPX L1 TEPX+TFPX)
+    'T29' : ( ','.join( [ 'SiPixelSimLorentzAngle_phase2_T25_v0_mc' ,SiPixelSimLARecord,connectionString, "", "2021-03-16 20:00:00.000"] ), ), #uH = 0.053/T (TBPX L2,L3,L4), uH=0.0/T (TBPX L1 TEPX+TFPX)
    'T30' : ( ','.join( [ 'SiPixelSimLorentzAngle_phase2_IT_v6.4.0_25x100_v1_mc' ,SiPixelSimLARecord,connectionString, "", "2021-12-03 16:00:00.000"] ), ), #uH = 0.053/T (TBPX), uH=0.0/T (TEPX+TFPX)
 }

 allTags["GenError"] = {


Just to check that nothing escaped: isn't "T29" needed for allTags["GenError"] and allTags["Template"]

As T29 has few TBPX modules with bricked planar pixels, there are no 'GenError' nor 'Template' payloads for this geometry.

perrotta · 2022-05-17T10:13:37Z

@emiglior if this is the "first commit", what we should expect from the "second" one? Aren't geometries T22,T23,T27,T28 already fully dropped with this PR?

emiglior · 2022-05-17T19:49:24Z

@emiglior if this is the "first commit", what we should expect from the "second" one? Aren't geometries T22,T23,T27,T28 already fully dropped with this PR?

@perrotta Indeed T22,T23,T27,T28 are fully dropped with this PR.
"first commit" it is a bad wording in the commit message... just to express that I was not confident that one iteration was enough

perrotta · 2022-05-18T05:16:04Z

+1

cmsbuild · 2022-05-18T05:16:27Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Drop tracker geometries T22,T23,T27,T28 - first commit

0017685

foo

cmsbuild added this to the CMSSW_12_4_X milestone May 9, 2022

cmsbuild added alca-pending code-checks-pending geometry-pending operations-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels May 9, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 9, 2022

cmsbuild added tests-started and removed tests-pending labels May 9, 2022

cmsbuild added tests-approved and removed tests-started labels May 10, 2022

cmsbuild added alca-approved and removed alca-pending labels May 10, 2022

cmsbuild mentioned this pull request May 10, 2022

DeepSC algorithm for ECAL SuperClusters #37115

Merged

cmsbuild added geometry-approved and removed geometry-pending labels May 10, 2022

cmsbuild removed the upgrade-pending label May 11, 2022

cmsbuild added the upgrade-approved label May 11, 2022

This was referenced May 13, 2022

Add Run-3 FastSim wf to runTheMatrix #37493

Merged

Phase2-gex134 Modify C17 to see the new numbering of HCAL #37951

Merged

BTV DQM Updates #37832

Merged

smuzaffar modified the milestones: CMSSW_12_4_X, CMSSW_12_5_X May 16, 2022

cmsbuild added pdmv-approved and removed pdmv-pending labels May 17, 2022

perrotta reviewed May 17, 2022

View reviewed changes

cmsbuild added fully-signed operations-approved orp-approved and removed operations-pending pending-signatures orp-pending labels May 18, 2022

cmsbuild merged commit 76b5f38 into cms-sw:master May 18, 2022

cmsbuild mentioned this pull request May 19, 2022

Adding DeepMET SONIC Producer to CMSSW #37963

Merged

emiglior mentioned this pull request May 24, 2022

Drop tracker geometry T29 (last with bricked pixels) #38061

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop tracker geometries T22,T23,T27,T28 - first commit #37874

Drop tracker geometries T22,T23,T27,T28 - first commit #37874

emiglior commented May 9, 2022

cmsbuild commented May 9, 2022

cmsbuild commented May 9, 2022

tvami commented May 9, 2022

cmsbuild commented May 10, 2022

tvami commented May 10, 2022

cvuosalo commented May 10, 2022

srimanob commented May 11, 2022

kskovpen commented May 17, 2022

perrotta May 17, 2022

emiglior May 17, 2022

perrotta commented May 17, 2022

emiglior commented May 17, 2022

perrotta commented May 18, 2022

cmsbuild commented May 18, 2022

Drop tracker geometries T22,T23,T27,T28 - first commit #37874

Drop tracker geometries T22,T23,T27,T28 - first commit #37874

Conversation

emiglior commented May 9, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 9, 2022

cmsbuild commented May 9, 2022

tvami commented May 9, 2022

cmsbuild commented May 10, 2022

Comparison Summary

tvami commented May 10, 2022

cvuosalo commented May 10, 2022

srimanob commented May 11, 2022

kskovpen commented May 17, 2022

perrotta May 17, 2022

Choose a reason for hiding this comment

emiglior May 17, 2022

Choose a reason for hiding this comment

perrotta commented May 17, 2022

emiglior commented May 17, 2022

perrotta commented May 18, 2022

cmsbuild commented May 18, 2022