Fix pat::Muon checksum

[makortel]

PR description:

Should fix the build failure discussed in #36179 (comment).

PR validation:

None, edited online.

[tvami]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36972/28340

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/PatCandidates/src/classes_def_objects.xml modified in PR(s): Implementation of beam halo tagger algorithm for the endcap photons #36901, Fix calculation of smeared MET on MiniAOD #36165

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• DataFormats/PatCandidates (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@gpetruc, @gouskos, @rovere, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jpata]

@cmsbuild please test

since in the original PR the test didn't catch this, I'm wondering what the test will show here

[tvami]

isnt there a way to test the full IB setup?

[makortel]

urgent

[tvami]

test parameters:

• full = true

[makortel]

isnt there a way to test the full IB setup?

There is, but I guess it wouldn't "catch" it either. The error is in the build log of the original PR, it just didn't propagate for some reason to the test status

[perrotta]

Naively looking at the error message: shouldn't class version be increased to 30?

[makortel]

Naively looking at the error message: shouldn't class version be increased to 30?

In principle yes, but in this specific case we can reuse 29 because we have not produced any data with version 29 (and the original PR should have used this value for 29). If we were fixing the class version e.g. a week from now, I would have increased the class version, but now we're talking about fixing it for the IB following the one that introduced 29.

[smuzaffar]

failure here are not related to this change. PR tests are using a working CMSW_12_3_X_2022-02-14-2300 IB + then changes which have been merged in master branch (but these changes require cmsdist updats too e.g. cms-sw/cmsdist#7626 ) .

[smuzaffar]

test parameters:

• pull_request = [Do not merge] just for testing cms-sw/cmssw#36972 cmsdist#7629

[smuzaffar]

please test

[perrotta]

+1

• Let have this merged for the next IB, even if tests haven't finished yet, and hope that it can be cleaner than the previous one.

[perrotta]

merge

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2737d8/22442/summary.html
COMMIT: 0a1108d
CMSSW: CMSSW_12_3_X_2022-02-14-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36972/22442/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cavana implements LLP displaced jet trigger in uGT emulator for CMSSW 12 3 x #36858
• @pmandrik Move ecalcalib_dqm_sourceclient to Run-3 era #36958
• @bsunanda Phase2-hgx300 Fix the rotation angle of layers in V16 geometry of HGCal #36945
• @mmusich remove more CMSDEPRECATED_X warnings in the AlCa/DB area #36962
• @lecriste Pattern Recognition validation for HGCal Tracksters #36712
• @fabferro PPS fix to comply to EDModule rules #36960
• @bsunanda Phase2-gex118 Correct the scenarios for using the correct Producer for GEM Reconstruction Geometry #36941
• @dan131riley Make some L1Trigger config static pointers thread safe #36965
• @tvami Add 2021 MinimumBias express and prompt reco wf to limited #36942
• @andrea21z Adding muon MVA ID #36179
• @kakwok Set receiveMuShower =true for uGT #36929
• @dinyar Add muon shower comparison plots #36928
• @bsunanda Run3-alca218B Clean some of the Hcal calibration code in the test area of Calibration/HcalCalibalgos #36964
• @wouf bug fixes for Hydjets and Pyquen #36918
• @missirol add support for L1T-MuonShowers as trigger objects at HLT #36951
• @thomreis ECAL - Remove unused parameters from the multifit algorithm #36935
• @belforte update crab-prod to last tested crab-dev cmsdist#7625
• @cms-sw Update tag for RecoMuon-MuonIdentification to V01-13-00 cmsdist#7626
• @cms-sw [Coral] Add const to char* to fix compiler errors with PyString_AsString cmsdist#7622

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2737d8/22442/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2737d8/22442/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2737d8/138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2737d8/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2737d8/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB

Summary:

• No significant changes to the logs found
• Reco comparison results: 8230 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3757427
• DQMHistoTests: Total failures: 104326
• DQMHistoTests: Total nulls: 20455
• DQMHistoTests: Total successes: 3632624
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -56760.095 KiB( 45 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 1.487 KiB L1TEMU/L1TdeStage2uGMT
• DQMHistoSizes: changed ( 23234.0,... ): -7096.313 KiB HGCAL/HGCalValidator
• Checked 193 log files, 42 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

Pull request #36972 was updated. @simonepigazzini, @vlimant can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2737d8/34792/summary.html
COMMIT: 0a1108d
CMSSW: CMSSW_13_3_X_2023-09-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36972/34792/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3348648
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3348626
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found