-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2021 MinimumBias express and prompt reco wf to limited #36942
Conversation
@cmsbuild , please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36942/28282
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@jordan-martins, @bbilin, @wajidalikhan, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12d18e/22368/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+Upgrade Maybe we should review a bit on the list of the short matrix, i.e. do we still need reco/express of 2011. |
@tvami maybe we should also add one wf for offline Run3 data, i.e. one from 139.001/139.002/139.003/139.004. We would have spostted the last failure with the L1CaloGeometry tag. |
Ok I removed the 2011 data based express and added the 139.001 |
@cmsbuild , please test |
Pull request #36942 was updated. @jordan-martins, @bbilin, @wajidalikhan, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12d18e/22412/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
I'm not sure I understand how this came back with a +1 |
Maybe @missirol could comment about this? |
.. The RelVal failing in the IBs is |
Yes, and both of them use the same thing in the HLT step, namely
|
My understanding is the following:
|
+Upgrade Re-sign. |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Noticed that
--limited
doesn't test the 2021 pilot beam express and prompt reco, so this PR add that two wf to itif this PR is a backport please specify the original PR and why you need to backport that PR:
N/A