-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back L1CaloGeometry tag to HLT GT #36971
Add back L1CaloGeometry tag to HLT GT #36971
Conversation
test parameters:
|
urgent
|
urgent
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36971/28339
|
@cmsbuild , please test |
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: Build BuildI found compilation error when building: /cvmfs/cms-ib.cern.ch/nweek-02720/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lRecoVertexLinearizationPointFinders /cvmfs/cms-ib.cern.ch/nweek-02720/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lRecoVertexVertexTools /cvmfs/cms-ib.cern.ch/nweek-02720/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lRecoVertexVertexPrimitives /cvmfs/cms-ib.cern.ch/nweek-02720/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lTrackingToolsTransientTrack /cvmfs/cms-ib.cern.ch/nweek-02720/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lDataFormatsPatCandidates collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc10/src/Alignment/MillePedeAlignmentAlgorithm/plugins/AlignmentMillePedeAlignmentAlgorithmAuto/libAlignmentMillePedeAlignmentAlgorithmAuto.so] Error 1 Leaving library rule at src/Alignment/MillePedeAlignmentAlgorithm/plugins Entering library rule at Alignment/MillePedeAlignmentAlgorithm >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-15-1100/src/Alignment/MillePedeAlignmentAlgorithm/src/MillePedeFileReader.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-15-1100/src/Alignment/MillePedeAlignmentAlgorithm/src/Mille.cc |
@cms-sw/orp-l2 this for sure is not connected to this PR, is this known? |
let me tag also @smuzaffar |
It is related to issues in IB, being discussed: |
Running locally the addOnTest I get this error for the
And I think the unitTest failing are also related to |
-1 Failed Tests: UnitTests RelVals RelVals-INPUT AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test runtestPhysicsToolsPatAlgos had ERRORS ---> test runtestTqafTopEventProducers had ERRORS ---> test runtestTqafTopEventSelection had ERRORS ---> test runtestTqafTopHitFit had ERRORS and more ... RelVals
Expand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...AddOn Tests
|
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-983196/22447/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
This PR adds back the
L1CaloGeometry_CRAFT09_hlt
tag to the HLT GT, as this was causing a crash first reported in #36940 (comment) and later discussed in #36940 (comment) and #36806.Since HLT experts are still in the process of investigating how to modify the producer that consumes this tag, we decided to add it back so it can be included in 12_3_0_pre5 and fix the IBs for now.
GT diff:
Run 3 data HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_dataRun3_HLT_v2/123X_dataRun3_HLT_v3
PR validation:
Validated with:
runTheMatrix.py -l 139.004 -j 8 --ibeos
Backport:
Already backported in #36948