Phase2-hgx300 Fix the rotation angle of layers in V16 geometry of HGCal

[bsunanda]

PR description:

Fix the rotation angle of layers in V16 geometry of HGCal

PR validation:

Tested using muon tomography

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36945/28289

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[srimanob]

@bsunanda
Is this ready to go for testing?

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c903b/22383/summary.html
COMMIT: a3a1e91
CMSSW: CMSSW_12_3_X_2022-02-13-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36945/22383/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7252 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3764435
• DQMHistoTests: Total failures: 98673
• DQMHistoTests: Total nulls: 121
• DQMHistoTests: Total successes: 3665619
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 45 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 193 log files, 42 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[srimanob]

Do we need the PR for D88 validation?
FYI @perrotta @qliphy

[bsunanda]

This is a bug fix for HGCal geometry in D86 and D88

…

________________________________ From: Phat Srimanobhas ***@***.*** Sent: 14 February 2022 12:31 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Phase2-hgx300 Fix the rotation angle of layers in V16 geometry of HGCal (PR #36945) Do we need the PR for D88 validation? FYI @perrotta<https://github.com/perrotta> @qliphy<https://github.com/qliphy> — Reply to this email directly, view it on GitHub<#36945 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOR6HEAJUHRR7HCF6LLU3DRYBANCNFSM5OF6ZIVQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[srimanob]

type bug-fix

[srimanob]

+Upgrade

The change is on Phase2 D86 and D88 which should be expected from this bug fix PR. I assume the validation will be done with CMSSW_12_3_0_pre5. I'm not sure if any plot in the PR test can confirm the fix.

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1