Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set receiveMuShower =true for uGT #36929

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

kakwok
Copy link
Contributor

@kakwok kakwok commented Feb 10, 2022

PR description:

Follow up of #36877, to enable global muon shower object unpacking at uGT.

receiveMuShower is an local variable to switch on unpacking global hadronic showers, the era dependent behaviour is controlled by the useMuonShowers parameter of the producer [here] and the snippet here.

PR validation:

Tested with L1Repack::FullMC on Run 3 signal MC and HLT menu with signal paths:

cmsDriver.py  l1Ntuple  --python_filename mc.py  -s L1REPACK:FullMC,RAW2DIGI  --mc -n -1\
--conditions auto:phase1_2021_realistic --era Run3 --no_output\
 --customise=L1Trigger/L1TNtuples/customiseL1Ntuple.L1NtupleRAWEMU\
  --customise=L1Trigger/Configuration/customiseUtils.L1TGlobalMenuXML\
 --filein /store/mc/Run3Summer21DRPremix/HTo2LongLivedTo4b_MH-1000_MFF-450_CTau-100000mm_TuneCP5_14TeV-pythia8/GEN-SIM-DIGI-RAW/120X_mcRun3_2021_realistic_v6-v2/2550000/e28c777d-10fd-4100-b230-c42b0160ad8a.root
hltGetConfiguration /users/kakwok/CSCCluster_12_3_X_signalsPath/V2\
 --mc --full --unprescale --globaltag auto:phase1_2021_realistic\
 --setup /dev/CMSSW_12_3_0/HLT/V21\
 --process MYHLT --output minimal\
 --l1Xml L1Menu_Collisions2022_v0_1_2.xml --l1-emulator FullMC\
 --input root://xrootd-cms.infn.it///store/mc/Run3Summer21DRPremix/HTo2LongLivedTo4b_MH-1000_MFF-450_CTau-100000mm_TuneCP5_14TeV-pythia8/GEN-SIM-DIGI-RAW/120X_mcRun3_2021_realistic_v6-v2/2550000/e28c777d-10fd-4100-b230-c42b0160ad8a.root >& hlt_FullMC_MC_new2.py

if this PR is a backport please specify the original PR and why you need to backport that PR:

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36929/28259

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kakwok for master.

It involves the following packages:

  • L1Trigger/L1TGlobal (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cecilecaillol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19dc2a/22395/summary.html
COMMIT: 5208920
CMSSW: CMSSW_12_3_X_2022-02-13-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36929/22395/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3764435
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3764399
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 459d69a into cms-sw:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants