more esConsumes in RecoPixelVertexing

[mmusich]

PR description:

Part of the migrations in #31061 and #36404.
Removed some CMSDEPRECATED_X warnings in the RecoPixelVertexing subsystem from CMSSW_12_3_CMSDEPRECATED_X_2022-01-21-2300.

PR validation:

cmssw compiles.
Run successfully: runTheMatrix.py -l limited --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36830/27998

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• RecoPixelVertexing/PixelLowPtUtilities (reconstruction)
• RecoPixelVertexing/PixelTriplets (reconstruction)
• RecoTracker/TkTrackingRegions (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f4d9a/22077/summary.html
COMMIT: cfae919
CMSSW: CMSSW_12_3_X_2022-01-29-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36830/22077/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /pool/condor/dir_263125/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-01-29-1100/src/RecoTracker/TkHitPairs/src/InnerDeltaPhi.cc
>> Compiling  /pool/condor/dir_263125/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-01-29-1100/src/RecoTracker/TkHitPairs/src/IntermediateHitDoublets.cc
>> Compiling  /pool/condor/dir_263125/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-01-29-1100/src/RecoTracker/TkHitPairs/src/LayerWithHits.cc
>> Compiling  /pool/condor/dir_263125/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-01-29-1100/src/RecoTracker/TkHitPairs/src/RecHitsSortedInPhi.cc
In file included from /pool/condor/dir_263125/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-01-29-1100/src/RecoTracker/TkHitPairs/src/HitPairGenerator.cc:1:
/pool/condor/dir_263125/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-01-29-1100/src/RecoTracker/TkHitPairs/interface/HitPairGenerator.h:30:26: error: 'const OrderedHitPairs& HitPairGenerator::run(const TrackingRegion&, const edm::Event&, const edm::EventSetup&)' marked 'override', but does not override
   30 |   const OrderedHitPairs& run(const TrackingRegion& region, const edm::Event& ev, const edm::EventSetup& es) override;
      |                          ^~~
In file included from /pool/condor/dir_263125/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-01-29-1100/src/RecoTracker/TkHitPairs/interface/CombinedHitPairGenerator.h:5,
                 from /pool/condor/dir_263125/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-01-29-1100/src/RecoTracker/TkHitPairs/src/CombinedHitPairGenerator.cc:1:
/pool/condor/dir_263125/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-01-29-1100/src/RecoTracker/TkHitPairs/interface/HitPairGenerator.h:30:26: error: 'const OrderedHitPairs& HitPairGenerator::run(const TrackingRegion&, const edm::Event&, const edm::EventSetup&)' marked 'override', but does not override


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 64 COMPILER='llvm compile'

>> Creating project symlinks
>> Entering Package RecoPixelVertexing/PixelLowPtUtilities
>> Entering Package RecoPixelVertexing/PixelTriplets
>> Entering Package RecoTracker/TkTrackingRegions
>> Compile sequence completed for CMSSW CMSSW_12_3_X_2022-01-29-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /pool/condor/dir_263125/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --ignoreWarning=Wdeprecated-declarations --logDir /pool/condor/dir_263125/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-01-29-1100/tmp/slc7_amd64_gcc10/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package RecoPixelVertexing/PixelLowPtUtilities
>> Compiling  /pool/condor/dir_263125/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-01-29-1100/src/RecoPixelVertexing/PixelLowPtUtilities/bin/ClusterShapeAnalyzer.cpp
Entering library rule at src/RecoPixelVertexing/PixelLowPtUtilities/bin


[jpata]

looks like a further esConsumes migration is needed in

cmssw/RecoTracker/TkHitPairs/interface/HitPairGenerator.h

Line 30 in cfae919

const OrderedHitPairs& run(const TrackingRegion& region, const edm::Event& ev, const edm::EventSetup& es) override;

due to the changes in OrderedHitsGenerator.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36830/28245

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #36830 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again.

[mmusich]

@jpata

looks like a further esConsumes migration is needed in

yes, that will apparently imply some further changes in many other interfaces that I really can't follow-up upon now. I've stripped the PR of the commit that doesn't allow to compile, so that this PR can go through fast.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f4d9a/22331/summary.html
COMMIT: 19b3263
CMSSW: CMSSW_12_3_X_2022-02-09-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36830/22331/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3764420
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3764396
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 193 log files, 42 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• technical

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1