-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-gex118 Correct the scenarios for using the correct Producer for GEM Reconstruction Geometry #36941
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36941/28281
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test test2026Geometry had ERRORS Comparison SummarySummary:
|
f9d236e
to
279864a
Compare
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36941/28288
|
Pull request #36941 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-83e476/22372/summary.html Comparison SummarySummary:
|
+1 |
Will this PR solve the issue of "GEM doesn’t pick up the DD4hep setup in GEMGeometryESModule ?" reported in |
Yes |
+Upgrade This PR is to fix the issue of Phase-2 DD4hep workflow that can't config DD4hep correctly for PR test can't be used to test the fix as we have several issues for Phase-2 DD4hep workflow. The local test with this PR, i.e. using
Thanks @bsunanda for the fix. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
type bug-fix |
+1 |
PR description:
Correct the scenarios for using the correct ESProducer for GEM Geometry
PR validation:
Use the runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special