DataFormats/FEDRawData UBSAN warning fixed

[smorovic]

Fixes UBSAN warning in:
#35035
12-bits are used for BX ID in the format, but a wider variable is used in C++ code. When compacted into FED header format, it would be truncated even if non-zero (which should not be the case with bx ID).

PR validation:

Behavior of the code doesn't change (operation is equivalent).

Fixes: #35035

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35039/24900

• This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35039/24900/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35039/24900/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[smorovic]

code-checks

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35039/24903

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @smorovic (Srecko Morovic) for master.

It involves the following packages:

• DataFormats/FEDRawData (daq)

@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smorovic]

please test

[mrodozov]

please test for CMSSW_12_1_UBSAN_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af52ce/18079/summary.html
COMMIT: b876620
CMSSW: CMSSW_12_1_X_2021-08-26-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35039/18079/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000324
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af52ce/18081/summary.html
COMMIT: b876620
CMSSW: CMSSW_12_1_UBSAN_X_2021-08-20-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35039/18081/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @jeongeun Migrate module configuration in PhysicsTools to use default cfipython #34973
• @makortel Migrate some modules in RecoHI to esConsumes() #34961
• @osschar [Fireworks/Geometry] Strip topolgy for sub-classes of StripTopology was not exported to RECO geometry. #34960
• @abhih1 Migrate leftover ECAL DQM codes to ESConsumes #34963
• @slava77 initialize TrackstersProducer::iterIndex_ to 0 #34962
• @bsunanda Run3-alca197 Add a possible AlCa stream for IsoTrackFilter useful for MC productions #34965
• @bsunanda Run3-sim103 Add tools to study big xml file which goes in the DB #34964
• @makortel Migrate some modules in SimTracker to esConsumes() #34967
• @makortel Migrate TrackingParticleNumberOfLayersProducer to esConsumes() #34969
• @makortel Restore cms::cuda::ESProduct construction without GPU #34968
• @makortel Migrate RPCRecHitProducer to esConsumes() #34945
• @makortel Remove MuonToSimAssociatorBase, MuonToSimAssociatorByHits, and TrackAssociatorRecord as obsolete #34944
• @makortel Migrate some modules in RecoMET to esConsumes() #34943
• @bsunanda Run3-hcx309 Rearrange the files to remove .h files from SimCalorimetry/HcalSimProducers/src #34940
• @ggovi Payload inspector framework moved to pybind11 #34672
• @bsunanda Run3-gex89 Attempt to define unqiue names of materials everywhere #34927
• @Dr15Jones Simplify setting EDPutTokenT via call to produces #34926
• @trackreco Update of mkFit for 12_1_0_pre2 #34921
• @tvami Add HCAL tag HcalRespCorrs_2021_v3.0_mc to Run-3 MC GTs #34922
• @bsunanda Run3-gex90 Make unique material names as default for all Run3 scenarios #34983
• @Dr15Jones Avoid memory overwrites in Ecal PayloadInspectors #34982
• @bsunanda Run3-alca198 Modify the analyzers to record muons not on event basis but on single muon basis #34980
• @Dr15Jones Fix infrequent deadlock in edm::ThreadHandoff #34984
• @maaraujo94 Adding an HLT filter based on PPS local track multiplicity conditions for selection of events for PPS PCL #34827
• @yuanchao Remove unused headers for CommonTools packages #34887
• @dildick New option in CSC DigiToRaw to pack strip digis by CFEB in each chamber.  #34783
• @bsunanda Run3-hcx310 Put back HcalDigiProducer.cc in SimCalorimetry/HcalSimProducers/src #34972
• @makortel Migrate some modules in RecoJets to esConsumes() #34959
• @Purva-Chaudhari Remove boost lexical_cast dependency in FWCore #34976
• @smuzaffar [Framework] Move publically used private headers in to interface dir #34977
• @cvuosalo [DD4hep] Revise order of materials to prevent delayed resolution of references #34974
• @makortel Migrate PFSimParticleProducer to esConsumes() #34938
• @bsunanda Run3-hcx308 Rearrange the files to remove .h files from SimCalorimetry/CastorSim/src #34939
• @makortel Migrate some modules in RecoTracker to esConsumes() #34934
• @makortel Migrate PFTauPrimaryVertexProducerBase to esConsumes() #34935
• @pieterdavid Update pileupCal.py using numpy #34931
• @gartung Utilities/StaticAnalyzers: Update function dumper to not add virtual at the end of function calls #35001
• @bsunanda Run3-hcx313 Rearrange the .h files in SimCalorimetry/HcalZeroSuppressionProducers #34998
• @Dr15Jones Use sufficient digits when converting a double #34999
• @makortel Migrate classes deriving from IsoDepositExtractor to esConsumes() #34996
• @missirol Fixing some edge cases in HLT-Patatrack customisations #34992

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af52ce/18081/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af52ce/18081/git-merge-result

Found compilation warnings

Unit Tests

I found errors in the following unit tests:

---> test testUCTUnpacker had ERRORS

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• You potentially added 21243 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 62905 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 396711
• DQMHistoTests: Total nulls: 38
• DQMHistoTests: Total successes: 2603581
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -45.455 KiB( 38 files compared)
• DQMHistoSizes: changed ( 136.731,... ): 0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 250202.181 ): -0.064 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.308 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 13 / 38 workflows

[smorovic]

+1
As far as I see, failed test is from an L1 raw data unpacker and is not related to this.
FEDRawData issue from #35035 doesn't appear in summary logs.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

please test for CMSSW_12_1_UBSAN_X
(there is a new 12_1_UBSAN release available since yesterday: let check if in that newer IB the unit test failure disappears)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af52ce/18111/summary.html
COMMIT: b876620
CMSSW: CMSSW_12_1_UBSAN_X_2021-08-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35039/18111/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 21301 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 61738 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 326669
• DQMHistoTests: Total nulls: 19
• DQMHistoTests: Total successes: 2673642
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.248 KiB( 38 files compared)
• DQMHistoSizes: changed ( 136.731,... ): 0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 250202.181 ): -0.064 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.308 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 13 / 38 workflows

[perrotta]

+1