-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Payload inspector framework moved to pybind11 #34672
Payload inspector framework moved to pybind11 #34672
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34672/24293
|
A new Pull Request was created by @ggovi for master. It involves the following packages:
@ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-151004/17308/summary.html Comparison SummarySummary:
|
(partial) duplicate of #34692 |
@ggovi , I would suggest to go ahead and sign this PR and we close the other one |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In the PayloadInspector module, we have adopted a binding C++/python to provide interoperability between the manipulation of payload data within the C++, and the rendering of plots in a python-based web application.
In this PR we replace the binding based on boost::python with pybind11.
The macro for the generation of the PayloadInspector plugins has been replaced and can be successfully applied to the various subsystems.
PR validation:
Unit/integration test + deployment in the DEMO slot within the Payload Inspector web app (Conddb browser )