Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payload inspector framework moved to pybind11 #34672

Merged
merged 3 commits into from
Aug 24, 2021

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Jul 28, 2021

PR description:

In the PayloadInspector module, we have adopted a binding C++/python to provide interoperability between the manipulation of payload data within the C++, and the rendering of plots in a python-based web application.
In this PR we replace the binding based on boost::python with pybind11.

The macro for the generation of the PayloadInspector plugins has been replaced and can be successfully applied to the various subsystems.

PR validation:

Unit/integration test + deployment in the DEMO slot within the Payload Inspector web app (Conddb browser )

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34672/24293

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for master.

It involves the following packages:

  • CondCore/EcalPlugins (db)
  • CondCore/SiPixelPlugins (db)
  • CondCore/SiStripPlugins (db)
  • CondCore/Utilities (db)

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @OzAmram, @ferencek, @dkotlins, @thomreis, @simonepigazzini, @mmusich, @VinInn, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jul 28, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-151004/17308/summary.html
COMMIT: 6b59c29
CMSSW: CMSSW_12_0_X_2021-07-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34672/17308/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998535
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Aug 8, 2021

(partial) duplicate of #34692

@smuzaffar
Copy link
Contributor

@ggovi , I would suggest to go ahead and sign this PR and we close the other one

@ggovi
Copy link
Contributor Author

ggovi commented Aug 23, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 24, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants