Removed lexical_cast boost dependency in CondCore #34932

Purva-Chaudhari · 2021-08-18T14:22:34Z

PR description:

Remove boost lexical cast dependency in CondCore with corresponding stl alternatives

PR validation:

Passed on scram -b runtests (CondCore)

if this PR is a backport please specify the original PR and why you need to backport that PR:

@davidlange6 @vgvassilev

cmsbuild · 2021-08-18T14:31:23Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34932/24745

This PR adds an extra 68KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CondCore/SiPixelPlugins/test/testSiPixelPayloadInspector.cpp modified in PR(s): Shift from Boost Python to Pybind11 #34692, Payload inspector framework moved to pybind11 #34672
- File CondCore/SiStripPlugins/test/testSiStripPayloadInspector.cpp modified in PR(s): Shift from Boost Python to Pybind11 #34692, Payload inspector framework moved to pybind11 #34672
- File CondCore/Utilities/plugins/BasicP_PayloadInspector.cc modified in PR(s): Payload inspector framework moved to pybind11 #34672
- File CondCore/Utilities/src/PayloadInspector.cc modified in PR(s): Shift from Boost Python to Pybind11 #34692, Payload inspector framework moved to pybind11 #34672

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34932/24745/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34932/24745/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-08-18T16:30:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34932/24750

This PR adds an extra 72KB to repository
Found files with invalid states:
- CondCore/Utilities/src/CondDBFetch.cc.rej:
  - Added: c2f3f43
  - Deleted: 4269894
There are other open Pull requests which might conflict with changes you have proposed:
- File CondCore/SiPixelPlugins/test/testSiPixelPayloadInspector.cpp modified in PR(s): Shift from Boost Python to Pybind11 #34692, Payload inspector framework moved to pybind11 #34672
- File CondCore/SiStripPlugins/test/testSiStripPayloadInspector.cpp modified in PR(s): Shift from Boost Python to Pybind11 #34692, Payload inspector framework moved to pybind11 #34672
- File CondCore/Utilities/plugins/BasicP_PayloadInspector.cc modified in PR(s): Payload inspector framework moved to pybind11 #34672
- File CondCore/Utilities/src/PayloadInspector.cc modified in PR(s): Shift from Boost Python to Pybind11 #34692, Payload inspector framework moved to pybind11 #34672

cmsbuild · 2021-08-18T16:30:40Z

A new Pull Request was created by @Purva-Chaudhari for master.

It involves the following packages:

CondCore/AlignmentPlugins (db)
CondCore/BeamSpotPlugins (db)
CondCore/DBOutputService (db, alca)
CondCore/HLTPlugins (hlt, db)
CondCore/RunInfoPlugins (db)
CondCore/SiPixelPlugins (db)
CondCore/SiStripPlugins (db)
CondCore/Utilities (db)

@malbouis, @yuanchao, @Martin-Grunewald, @cmsbuild, @tlampen, @ggovi, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@tocheng, @VinInn, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami · 2021-08-18T16:32:40Z

@cmsbuild , please test

cmsbuild · 2021-08-18T19:51:23Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0031d0/17863/summary.html
COMMIT: 4269894
CMSSW: CMSSW_12_1_X_2021-08-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34932/17863/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000352
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000324
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

tvami · 2021-08-18T20:34:15Z

+alca

Martin-Grunewald · 2021-08-19T07:45:11Z

+1

cmsbuild · 2021-08-24T11:26:34Z

Pull request #34932 was updated. @malbouis, @yuanchao, @Martin-Grunewald, @cmsbuild, @tlampen, @ggovi, @pohsun, @francescobrivio, @tvami can you please check and sign again.

smuzaffar · 2021-08-24T11:31:29Z

please test

cmsbuild · 2021-08-24T14:52:31Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0031d0/17995/summary.html
COMMIT: b0b7081
CMSSW: CMSSW_12_1_X_2021-08-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34932/17995/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0031d0/17995/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0031d0/17995/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000352
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3000324
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

Martin-Grunewald · 2021-08-25T07:14:22Z

+1

yuanchao · 2021-08-25T10:07:27Z

CondCore/SiPixelPlugins/plugins/SiPixelFEDChannelContainer_PayloadInspector.cc

@@ -82,7 +82,7 @@ namespace {
      auto paramValues = PlotBase::inputParamValues();
      auto ip = paramValues.find("Scenarios");
      if (ip != paramValues.end()) {
-        auto input = boost::lexical_cast<std::string>(ip->second);
+        auto input = ip->second;


So casting is not needed here?

It is already of type string

yuanchao · 2021-08-25T10:08:18Z

CondCore/SiStripPlugins/plugins/SiStripPedestals_PayloadInspector.cc

@@ -116,7 +116,7 @@ namespace {
      auto paramValues = PlotBase::inputParamValues();
      auto ip = paramValues.find("DetIds");
      if (ip != paramValues.end()) {
-        auto input = boost::lexical_cast<std::string>(ip->second);
+        auto input = ip->second;


So casting is not needed here? (same as in SiPixelFEDChannelContainer_PayloadInspector.cc)

yuanchao · 2021-08-30T12:21:54Z

+1

technical
unit tests passed

davidlange6 · 2021-09-07T07:51:13Z

hi @ggovi - any comments?

ggovi · 2021-09-07T08:02:54Z

+1

cmsbuild · 2021-09-07T08:03:17Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-09-07T08:46:50Z

+1

Removed lexical_cast boost dependency

f107145

cmsbuild added this to the CMSSW_12_1_X milestone Aug 18, 2021

cmsbuild added alca-pending code-checks-pending db-pending hlt-pending orp-pending pending-signatures tests-pending labels Aug 18, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 18, 2021

applied checks

c2f3f43

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 18, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 18, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 18, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 18, 2021

cmsbuild added alca-approved and removed alca-pending labels Aug 18, 2021

cmsbuild removed the hlt-pending label Aug 19, 2021

cmsbuild added the code-checks-approved label Aug 24, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 24, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 24, 2021

cmsbuild added hlt-approved and removed hlt-pending labels Aug 25, 2021

yuanchao reviewed Aug 25, 2021

View reviewed changes

cmsbuild mentioned this pull request Aug 25, 2021

Adapt CAConstants for HIon #34811

Closed

cmsbuild added alca-approved and removed alca-pending labels Aug 30, 2021

cmsbuild mentioned this pull request Sep 6, 2021

Added PPSAlignmentConfiguration - a new conditions format for PPS global alignment #35174

Merged

cmsbuild added db-approved and removed db-pending pending-signatures labels Sep 7, 2021

cmsbuild added the fully-signed label Sep 7, 2021

cmsbuild added orp-approved and removed orp-pending labels Sep 7, 2021

cmsbuild merged commit a881d4a into cms-sw:master Sep 7, 2021

Purva-Chaudhari deleted the testbranch_lexical_cast branch September 7, 2021 09:05

cmsbuild mentioned this pull request Sep 8, 2021

Updated root to tip of branch v6-24-00-patches cms-sw/cmsdist#7271

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed lexical_cast boost dependency in CondCore #34932

Removed lexical_cast boost dependency in CondCore #34932

Purva-Chaudhari commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

tvami commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

tvami commented Aug 18, 2021

Martin-Grunewald commented Aug 19, 2021

cmsbuild commented Aug 24, 2021

smuzaffar commented Aug 24, 2021

cmsbuild commented Aug 24, 2021

Martin-Grunewald commented Aug 25, 2021

yuanchao Aug 25, 2021

Purva-Chaudhari Aug 25, 2021

yuanchao Aug 25, 2021

yuanchao commented Aug 30, 2021

davidlange6 commented Sep 7, 2021

ggovi commented Sep 7, 2021

cmsbuild commented Sep 7, 2021

perrotta commented Sep 7, 2021

Removed lexical_cast boost dependency in CondCore #34932

Removed lexical_cast boost dependency in CondCore #34932

Conversation

Purva-Chaudhari commented Aug 18, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

tvami commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

Comparison Summary

tvami commented Aug 18, 2021

Martin-Grunewald commented Aug 19, 2021

cmsbuild commented Aug 24, 2021

smuzaffar commented Aug 24, 2021

cmsbuild commented Aug 24, 2021

Comparison Summary

Martin-Grunewald commented Aug 25, 2021

yuanchao Aug 25, 2021

Choose a reason for hiding this comment

Purva-Chaudhari Aug 25, 2021

Choose a reason for hiding this comment

yuanchao Aug 25, 2021

Choose a reason for hiding this comment

yuanchao commented Aug 30, 2021

davidlange6 commented Sep 7, 2021

ggovi commented Sep 7, 2021

cmsbuild commented Sep 7, 2021

perrotta commented Sep 7, 2021