Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM Pixel Phase 1: Several new Efficiency trend plots #34384

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

SissonJ
Copy link
Contributor

@SissonJ SissonJ commented Jul 7, 2021

Additions to DQM/SiPixelPhase1
Added new trend plots:

  • Efficiency vs LS: Barrel & Endcap -- new specification in SiPixelPhase1Track
  • Efficiency vs Mean number of vertices: Barrel & Endcap -- new DQMEDHarvester in SiPixelPhase1Track
  • Efficiency vs Instantaneous Luminosity: Barrel & Endcap -- new DQMEDHarvester in SiPixelPhase1Track

Related talks:
https://indico.cern.ch/event/1000808/contributions/4355849/attachments/2241277/3800219/TrackerDQM5_7_21.pdf
https://indico.cern.ch/event/934813/contributions/4103234/attachments/2142978/3611403/PixelEfficiencyTrendPlots_111320.pdf

Tested with runTheMatrix.py -l 136.892
Tested missing lumiVsLS protection with fake HLT runTheMatrix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34384/23773

  • This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34384/23775

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

A new Pull Request was created by @SissonJ (Jack Sisson) for master.

It involves the following packages:

DQM/SiPixelPhase1Common
DQM/SiPixelPhase1Config
DQM/SiPixelPhase1Track

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@@ -546,6 +541,7 @@ void HistogramManager::executePerLumiHarvesting(DQMStore::IBooker& iBooker,
}

void HistogramManager::loadFromDQMStore(SummationSpecification& s, Table& t, DQMStore::IGetter& iGetter) {
//std::cout << "Running the loadFromDQMStore function" << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part of the debugging changes? Perhaps to remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed!

#Barycenter plots
from DQM.SiPixelPhase1Summary.SiPixelBarycenter_cfi import *

from RecoPixelVertexing.PixelLowPtUtilities.ClusterShapeHitFilterESProducer_cfi import *
from RecoLocalTracker.SiStripClusterizer.SiStripClusterChargeCut_cfi import *


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cfi is importing the module but SiPixelPhase1EfficiencyExtras is not added to the sequence, is this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in OfflineDQM_source_cff is imported to OfflineDQM_harvesting_cff:
from DQM.SiPixelPhase1Config.SiPixelPhase1OfflineDQM_source_cff import *

The sequence this module appears in is: siPixelPhase1OfflineDQM_harvesting

@@ -97,6 +92,7 @@
+ SiPixelPhase1TrackResidualsHarvester
+ RunQTests_online
+ SiPixelPhase1SummaryOnline
+ SiPixelPhase1EfficiencyExtras
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is affecting Online DQM but we cannot test it at present at P5 because it runs 11_3_X, have you tested it on your side too? When would you need these plots in Online, for CRAFT in August? Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking with group conveners. Our development was in 11_1_X, but we haven't explicitly tested Online. The plots are not urgent for CRAFT.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfernan2 in principle this can wait till CRAFT. Jacob is testing with the online client privately now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK thanks. I was asking because this PR is in 12_0_X and 12_0_0 should be ready by the end of August, since CMSSW_12_0_0 is expected to be used in the LHC beam test scheduled by the last week of September. So I am afraid that not for CRAFT...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should just backport it, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfernan2 Removed this Harvester from online since it is only needed in offline!

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34384/23778

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

Pull request #34384 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Jul 7, 2021

please test

<Notes on implementation>
*/
//
// Original Author: Duncan Leggat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SissonJ is this accurate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34384/24920

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #34384 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Aug 27, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d208a8/18099/summary.html
COMMIT: 6c4b2f0
CMSSW: CMSSW_12_1_X_2021-08-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34384/18099/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000352
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3000324
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7980.553 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 613.889 KiB PixelPhase1/Tracks
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 30, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants