Run3-hcx308 Rearrange the files to remove .h files from SimCalorimetry/CastorSim/src #34939

bsunanda · 2021-08-18T19:27:50Z

PR description:

Rearrange the files to remove .h files from SimCalorimetry/CastorSim/src

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2021-08-18T19:35:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34939/24759

This PR adds an extra 24KB to repository

cmsbuild · 2021-08-18T19:36:05Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

SimCalorimetry/CastorSim (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2021-08-18T19:49:50Z

@cmsbuild Please test

cmsbuild · 2021-08-18T23:07:46Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-696378/17873/summary.html
COMMIT: 5dd73cf
CMSSW: CMSSW_12_1_X_2021-08-18-1500/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34939/17873/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000352
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3000318
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

civanch · 2021-08-20T07:38:31Z

+1

cmsbuild · 2021-08-20T07:39:01Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-08-20T13:00:39Z

SimCalorimetry/CastorSim/plugins/CastorDigiAnalyzer.cc

+#include "FWCore/Utilities/interface/InputTag.h"
+#include "SimCalorimetry/CaloSimAlgos/interface/CaloHitAnalyzer.h"
+#include "SimCalorimetry/CaloSimAlgos/interface/CaloValidationStatistics.h"
+#include "SimCalorimetry/CaloSimAlgos/interface/CaloHitAnalyzer.h"


Duplicate of line 13

perrotta · 2021-08-20T13:07:08Z

SimCalorimetry/CastorSim/plugins/CastorDigiAnalyzer.h

@@ -9,8 +9,8 @@
 #include "FWCore/Utilities/interface/InputTag.h"


This file was included in CastorDigiAnalyzer.cc, and it should therefore get removed

perrotta · 2021-08-20T13:08:03Z

SimCalorimetry/CastorSim/plugins/CastorDigiProducer.h

@@ -11,14 +11,14 @@
 #include "Geometry/Records/interface/CaloGeometryRecord.h"


This file was included in CastorDigiProducer.cc, and it should therefore get removed

perrotta · 2021-08-20T13:08:59Z

SimCalorimetry/CastorSim/plugins/CastorHitAnalyzer.h

@@ -7,8 +7,8 @@
 #include "FWCore/ParameterSet/interface/ParameterSet.h"


This file was included in CastorHitAnalyzer.cc, and it should therefore get removed

bsunanda · 2021-08-20T13:30:04Z

@cmsbuild Please test

cmsbuild · 2021-08-20T13:35:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34939/24794

This PR adds an extra 24KB to repository

cmsbuild · 2021-08-20T13:35:53Z

Pull request #34939 was updated. @civanch, @mdhildreth can you please check and sign again.

cmsbuild · 2021-08-20T16:32:30Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-696378/17923/summary.html
COMMIT: 43b5d8c
CMSSW: CMSSW_12_1_X_2021-08-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34939/17923/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000352
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000324
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

civanch · 2021-08-20T20:49:45Z

+1

cmsbuild · 2021-08-20T20:50:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-08-20T21:13:38Z

+1

Reaarange the files to remove .h files from SimCalorimetry/CastorSim/src

5dd73cf

cmsbuild added this to the CMSSW_12_1_X milestone Aug 18, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures simulation-pending tests-pending labels Aug 18, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 18, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 18, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 18, 2021

cmsbuild added fully-signed simulation-approved and removed simulation-pending pending-signatures labels Aug 20, 2021

perrotta reviewed Aug 20, 2021

View reviewed changes

Take care of Andrea's comments

43b5d8c

cmsbuild added code-checks-pending and removed simulation-approved fully-signed tests-approved code-checks-approved labels Aug 20, 2021

cmsbuild added pending-signatures simulation-pending tests-pending labels Aug 20, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 20, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 20, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 20, 2021

cmsbuild added fully-signed simulation-approved and removed simulation-pending pending-signatures labels Aug 20, 2021

cmsbuild added orp-approved and removed orp-pending labels Aug 20, 2021

cmsbuild merged commit 1db891a into cms-sw:master Aug 20, 2021

This was referenced Aug 21, 2021

Run3-hcx310 Put back HcalDigiProducer.cc in SimCalorimetry/HcalSimProducers/src #34972

Merged

DataFormats/FEDRawData UBSAN warning fixed #35039

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-hcx308 Rearrange the files to remove .h files from SimCalorimetry/CastorSim/src #34939

Run3-hcx308 Rearrange the files to remove .h files from SimCalorimetry/CastorSim/src #34939

bsunanda commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

bsunanda commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

civanch commented Aug 20, 2021

cmsbuild commented Aug 20, 2021

perrotta Aug 20, 2021

perrotta Aug 20, 2021

perrotta Aug 20, 2021

perrotta Aug 20, 2021

bsunanda commented Aug 20, 2021

cmsbuild commented Aug 20, 2021

cmsbuild commented Aug 20, 2021

cmsbuild commented Aug 20, 2021

civanch commented Aug 20, 2021

cmsbuild commented Aug 20, 2021

perrotta commented Aug 20, 2021

		@@ -9,8 +9,8 @@
		#include "FWCore/Utilities/interface/InputTag.h"

		@@ -11,14 +11,14 @@
		#include "Geometry/Records/interface/CaloGeometryRecord.h"

		@@ -7,8 +7,8 @@
		#include "FWCore/ParameterSet/interface/ParameterSet.h"

Run3-hcx308 Rearrange the files to remove .h files from SimCalorimetry/CastorSim/src #34939

Run3-hcx308 Rearrange the files to remove .h files from SimCalorimetry/CastorSim/src #34939

Conversation

bsunanda commented Aug 18, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

bsunanda commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

Comparison Summary

civanch commented Aug 20, 2021

cmsbuild commented Aug 20, 2021

perrotta Aug 20, 2021

Choose a reason for hiding this comment

perrotta Aug 20, 2021

Choose a reason for hiding this comment

perrotta Aug 20, 2021

Choose a reason for hiding this comment

perrotta Aug 20, 2021

Choose a reason for hiding this comment

bsunanda commented Aug 20, 2021

cmsbuild commented Aug 20, 2021

cmsbuild commented Aug 20, 2021

cmsbuild commented Aug 20, 2021

Comparison Summary

civanch commented Aug 20, 2021

cmsbuild commented Aug 20, 2021

perrotta commented Aug 20, 2021