-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused headers for CommonTools packages #34887
Conversation
@yuanchao, CMSSW_12_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34887/24697
|
A new Pull Request was created by @yuanchao (Yuan CHAO) for master. It involves the following packages:
@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-878f89/17799/summary.html Comparison SummarySummary:
|
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34887/24790
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Looks like a bad idea to use restore instead of rebase. Anyway, taking the chance to fix the code checks. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34887/24791
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-878f89/17920/summary.html Comparison SummarySummary:
|
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Remove unused header for packages #3
Following the issue #31505, the following headers are unused in CommonTools package:
This is the third batch of the unused header removal.
PR validation:
Code compiles. Run local limited runTheMatrix.py tests.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport and no backport forseen