Remove MuonToSimAssociatorBase, MuonToSimAssociatorByHits, and TrackAssociatorRecord as obsolete

[makortel]

PR description:

The #34924 removed last ESProduct from TrackAssociatorRecord, so the record can be removed now (as can the full subpackage as there would be nothing left).

The record was still being used in testAssociatorRecoMuon, but that test EDModule has been effectively dysfunctional since #8635 where all the corresponding ESProducers were removed. That EDModule, and the MuonToSimAssociatorBase and MuonToSimAssociatorByHits could have been removed already in #8635.

Resolves cms-sw/framework-team#225.

PR validation:

Code compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34944/24767

• This PR adds an extra 152KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• Calibration/IsolatedParticles (alca)
• MuonAnalysis/MuonAssociators (analysis)
• RecoMuon/GlobalTrackingTools (reconstruction)
• RecoVertex/ConfigurableVertexReco (reconstruction)
• RecoVertex/KalmanVertexFit (reconstruction)
• SimMuon/MCTruth (simulation)
• SimTracker/Records (simulation)
• SimTracker/TrackAssociation (simulation)
• SimTracker/TrackHistory (simulation)
• SimTracker/VertexAssociation (simulation)
• Validation/RecoEgamma (dqm)
• Validation/RecoMuon (dqm)
• Validation/RecoTrack (dqm)
• Validation/RecoVertex (dqm)

@malbouis, @civanch, @yuanchao, @kmaeshima, @tlampen, @andrius-k, @mdhildreth, @rvenditti, @cmsbuild, @jfernan2, @ahmad3213, @slava77, @jpata, @ErnestaP, @pohsun, @francescobrivio, @santocch, @tvami can you please review it and eventually sign? Thanks.
@echabert, @emilbols, @felicepantaleo, @abbiendi, @robervalwalsh, @bsunanda, @demuller, @threus, @mmusich, @cericeci, @venturia, @JyothsnaKomaragiri, @JanFSchulte, @jhgoh, @dgulhan, @prolay, @HuguesBrun, @slomeo, @trocino, @rociovilar, @sscruz, @pieterdavid, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @tocheng, @wmtford, @ebrondol, @mtosi, @amagitte, @AlexDeMoor, @battibass, @gbenelli, @Fedespring, @calderona, @andrzejnovak this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00ca3c/17879/summary.html
COMMIT: b19bdaa
CMSSW: CMSSW_12_1_X_2021-08-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34944/17879/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 5 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00ca3c/17879/llvm-analysis/esrget-sa.txt for details.
CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00ca3c/17879/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000324
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[jfernan2]

+1

[civanch]

+1

[slava77]

+reconstruction

for #34944 b19bdaa

• code changes in reco are somewhat trivial (removing unused includes or update of package deps)
• jenkins tests pass

[perrotta]

+1

• Remove unused code and references to it
• Bypassing @cms-sw/analysis-l2 signature
• @abbiendi FYI

[perrotta]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.