-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate (Cosmic)ParametersDefinerForTP to esConsumes() #34924
Migrate (Cosmic)ParametersDefinerForTP to esConsumes() #34924
Conversation
Changed the (Cosmic)ParametersDefinerForTP from ESProducts to helper classes.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34924/24733
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@civanch, @kmaeshima, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @jfernan2, @ahmad3213, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c04a47/17844/summary.html Comparison SummarySummary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Part of #31061. The (
Cosmic
)ParametersDefinerForTP
were ESProducts that read data products fromEvent
andEventSetup
. Their API looked like the simplest way to migrate them to EventSetup-consumes would be to transform them to helper classes. All the corresponding ESProducer and configuration infrastructure is removed in this PR.In addition this PR removes unnecessary dependencies to
boost
androot
fromSimTracker/TrackAssociation
.Resolves cms-sw/framework-team#224.
PR validation:
Limited matrix runs.