-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TMB matching parameters for CSC trigger primitives #34308
Update TMB matching parameters for CSC trigger primitives #34308
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34308/23641
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: L1Trigger/CSCTriggerPrimitives @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5ad07/16405/summary.html Comparison SummarySummary:
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34308/23658
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
This is the most recent report from the B904 test-stand after relocating the CCLUT part in the CLCT processors. CSC_dataVsEmul_B904_Cosmic_Run_210609_142357_20210702_RelocateCCLUT.pdf I don't see any changes in the CLCT or LCT histograms. The relocating does make sense; in the firmware CCLUT is also only applied after the pattern finding is complete. But there are still 15 too many CLCTs found after re-emulation of 10,000 events, pointing to possibly an issue with finding the second CLCT (work in progress). |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34308/23660
|
Pull request #34308 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5ad07/16457/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Three parameters I forgot to update in #34245.
matchEarliestClctOnly
). With the introduction of the preferred BX windows, we now also do this in Run-3 and Phase-2.tmbDropUsedClcts
was mistakenly set to False for Run-2. That should be True. But it is False for Run-3 and Phase-2; CLCTs can be reused.tmbL1aWindowSize
) is 5 BX wide, not 7.PR validation:
Code was tested on 10k events of B904 cosmic data (to test Run-3 algorithm).
DataVsEmulatorComparison_20210701.pdf
It was also tested on 26k events of 2018D ZeroBias data Run 322022 (to test Run-2 algorithm). Chambers ME+1/1/9, ME+1/1/10 and ME+1/1/11 were excluded in this comparison because we had loaded prototype Phase-2 firmware on those chambers.
CSC_dataVsEmul_CMS_Run_322022_20210701_prefix.pdf
CSC_dataVsEmul_CMS_Run_322022_20210701_postfix.pdf
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
Before submitting your pull requests, make sure you followed this checklist: