-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate service from T25&T26 #34388
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34388/23779
|
A new Pull Request was created by @adewit for master. It involves the following packages: Geometry/TrackerCommonData (geometry) @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
-1 Failed Tests: RelVals RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals
Expand to see more relval errors ...RelVals-INPUT
|
errors are unrelated, see #34215 (comment) |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c2b0b/16634/summary.html Comparison SummarySummary:
|
Comparison differences are due to a problem recently fixed by #34409. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This removes a duplicate, ill-defined, service from the XMLs for T25 and T26, which was flagged up by DD4hep tests @bsunanda was running. (It should never have been there, but did not lead to any obvious errors in other tests)
PR validation:
Checked runTheMatrix workflow for these geometries still runs without problems and that with this change the new test
dumpTrackerDD4Hep_cfg.py
inGeometry/TrackerCommonData
does not crash.if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport