-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new plots to ECAL Offline DQM with Pedestal and Laser transparency correction from the Database #34342
Add new plots to ECAL Offline DQM with Pedestal and Laser transparency correction from the Database #34342
Conversation
…y correction from the DB
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34342/23713
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34342/23714
|
A new Pull Request was created by @abhih1 (Abhirami Harilal) for master. It involves the following packages: DQM/EcalMonitorTasks @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34342/23725
|
Pull request #34342 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dac607/16498/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
At the request of the ECAL DPG, new plots are added to the Offline DQM workflow, involving pedestal RMS values and laser transparency correction of crystals, read from the database directly, as functions of eta.
These plots would be useful in general for Offline DQM and also crucial in understanding if the conditions loaded by CMSSW changes from one run to the other in RelVal MC validation.
PR validation:
The code changes were validated by running the DQM relval workflow 136.874 using the runTheMatrix script
runTheMatrix.py -l 136.874 --ibeos
The resultant DQM output file was examined by uploading it to an Offline DQM test GUI and confirming the new plots.
The plots were also approved by the ECAL DPG team.
Backport:
A backport PR to CMSSW_11_3_X has been created here: #34341