-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with SiPixelQualityMapComparisonBase #34326
Fix issues with SiPixelQualityMapComparisonBase #34326
Conversation
type bug-fix |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34326/23675
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondCore/SiPixelPlugins @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @ggovi, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
…s it was a real diff
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34326/23676
|
Pull request #34326 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @ggovi, @rvenditti can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-658959/16451/summary.html Comparison SummarySummary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34326/23683
|
Pull request #34326 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @ggovi, @rvenditti can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-658959/16458/summary.html Comparison SummarySummary:
|
+1 |
@ggovi can you please sign this? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is a follow-up to PR #34071.
Fixes two issues found when displaying plots in the payload inspector in CondDB:
SiPixel*QualityMapCompareTwoTags
in order to be in single IOV mode;Phase1PixelROCMaps
the in "delta" mode, when an empty map was produced (leading to division by zero); such case is now tested in the unit tests.PR validation:
Tested with the command:
which was failing before (killed) while now produces:
Also the (augmented) unit test pass.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, no backport needed.