Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DQM] Move to python3 all scripts in DQMServices #34374

Merged
merged 3 commits into from
Jul 7, 2021

Conversation

jfernan2
Copy link
Contributor

@jfernan2 jfernan2 commented Jul 7, 2021

PR description:

Since CMSSW_12_0_X_2021-07-06-0300 DQM Bin By Bin tool is crashing in Jenkins tests. It looks like Jenkins test is already using python3.
This PR is urgently needed to put back the Bin By Bin tool

@jfernan2
Copy link
Contributor Author

jfernan2 commented Jul 7, 2021

urgent

@jfernan2
Copy link
Contributor Author

jfernan2 commented Jul 7, 2021

+1

@jfernan2
Copy link
Contributor Author

jfernan2 commented Jul 7, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34374/23757

  • This PR adds an extra 60KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

DQMServices/Components
DQMServices/Demo
DQMServices/FileIO
DQMServices/StreamerIO

can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34374/23759

  • This PR adds an extra 60KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

Pull request #34374 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

@jfernan2
Copy link
Contributor Author

jfernan2 commented Jul 7, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34374/23760

  • This PR adds an extra 64KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

Pull request #34374 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27b877/16538/summary.html
COMMIT: 4205514
CMSSW: CMSSW_12_0_X_2021-07-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34374/16538/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785924
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2785895
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor Author

jfernan2 commented Jul 7, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 7, 2021

+1

@smuzaffar
Copy link
Contributor

smuzaffar commented Jul 8, 2021

@jfernan2 , looks like DQM bin by bin comparison still failing

Running comparison:
compareHistograms.py -b CMSSW_12_0_X_2021-07-07-2300/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/DQM_V0001_R000165121__Global__CMSSW_X_Y_Z__RECO.root -p PR-31e7d3/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/DQM_V0001_R000165121__Global__CMSSW_X_Y_Z__RECO.root -o dqm-comparison/dqmComparisonOutput/ -n cmssw_34401 -t 16609 -r CMSSW_12_0_X_2021-07-07-2300
Exception comparing two root files: a bytes-like object is required, not 'str'
Exception comparing two root files: a bytes-like object is required, not 'str'

can you please test

jfernan2 added a commit to jfernan2/cmssw that referenced this pull request Jul 8, 2021
@jfernan2
Copy link
Contributor Author

jfernan2 commented Jul 8, 2021

Thanks @smuzaffar
I have created #34411

sifuluo pushed a commit to sifuluo/cmssw that referenced this pull request Sep 1, 2021
@@ -1,4 +1,4 @@
#!/usr/bin/env python
#!/usr/bin/env python3
Copy link
Contributor

@mmusich mmusich Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants